# \[PATCH v4 3/5\] nvme-fabrics: avoid double request completion for nvmf\_fail\_nonready\_command - From: Chao Leng \ - Date: 2021-01-26 18:53:09 - List: linux-block - Page: https://ratatoskr.run/linux-block/2021/01/6400528 - Thread: https://ratatoskr.run/linux-nvme/2021/01/6400526/t.md ```text When reconnect, the request may be completed with NVME_SC_HOST_PATH_ERROR in nvmf_fail_nonready_command. The state of request will be changed to MQ_RQ_IN_FLIGHT before call nvme_complete_rq. If free the request asynchronously such as in nvme_submit_user_cmd, in extreme scenario the request may be completed again in tear down process. nvmf_fail_nonready_command do not need calling blk_mq_start_request before complete the request. nvmf_fail_nonready_command should set the state of request to MQ_RQ_COMPLETE before complete the request. Signed-off-by: Chao Leng --- drivers/nvme/host/fabrics.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 72ac00173500..40f40c0debc1 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -553,9 +553,7 @@ blk_status_t nvmf_fail_nonready_command(struct nvme_ctrl *ctrl, !blk_noretry_request(rq) && !(rq->cmd_flags & REQ_NVME_MPATH)) return BLK_STS_RESOURCE; - nvme_req(rq)->status = NVME_SC_HOST_PATH_ERROR; - blk_mq_start_request(rq); - nvme_complete_rq(rq); + nvme_complete_failed_rq(rq, NVME_SC_HOST_PATH_ERROR); return BLK_STS_OK; } EXPORT_SYMBOL_GPL(nvmf_fail_nonready_command); -- 2.16.4 ```