[PATCH RESEND] blkcg: delete redundant get/put operations for queue

Subsystems: block layer, control group - block io controller (blkio), the rest

STALE2050d REVIEWED: 6 (6M)

1 review trailer (1 from subsystem maintainers).

2 messages, 2 authors, 2021-01-26 · open the first message on its own page

[PATCH RESEND] blkcg: delete redundant get/put operations for queue

From: Chunguang Xu <hidden>
Date: 2021-01-25 05:07:02

From: Chunguang Xu <redacted>

When calling blkcg_schedule_throttle(), for the same queue,
redundant get/put operations can be removed.

Signed-off-by: Chunguang Xu <redacted>
Acked-by: Tejun Heo <tj@kernel.org>
---
 block/blk-cgroup.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 031114d..e9b264b 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1757,12 +1757,15 @@ void blkcg_schedule_throttle(struct request_queue *q, bool use_memdelay)
 	if (unlikely(current->flags & PF_KTHREAD))
 		return;
 
-	if (!blk_get_queue(q))
-		return;
+	if (current->throttle_queue != q) {
+		if (!blk_get_queue(q))
+			return;
+
+		if (current->throttle_queue)
+			blk_put_queue(current->throttle_queue);
+		current->throttle_queue = q;
+	}
 
-	if (current->throttle_queue)
-		blk_put_queue(current->throttle_queue);
-	current->throttle_queue = q;
 	if (use_memdelay)
 		current->use_memdelay = use_memdelay;
 	set_notify_resume(current);
-- 
1.8.3.1

Re: [PATCH RESEND] blkcg: delete redundant get/put operations for queue

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-01-26 22:08:56

On 1/24/21 10:05 PM, Chunguang Xu wrote:
From: Chunguang Xu <redacted>

When calling blkcg_schedule_throttle(), for the same queue,
redundant get/put operations can be removed.
Applied, thanks.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help