# Re: \[PATCH\] block: Fix an error handling in add\_partition

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2021-01-20 10:30:33 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2021/01/6241038
- Thread: https://ratatoskr.run/linux-block/2021/01/6237571/t.md

```text
On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
> 
> Signed-off-by: Dinghao Liu <redacted>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
```