Re: [PATCH 2/2] blk-snap - snapshots and change-tracking for block devices
From: Pavel Machek <hidden>
Date: 2020-10-21 09:08:45
We'll need some changelog here.
Signed-off-by: Sergei Shtepa <redacted>
quoted hunk
--- /dev/null +++ b/drivers/block/blk-snap/blk-snap-ctl.h@@ -0,0 +1,190 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#pragma once
once?
quoted hunk
+#define MODULE_NAME "blk-snap" +#define SNAP_IMAGE_NAME "blk-snap-image" + +#define SUCCESS 0 + +#define MAX_TRACKING_DEVICE_COUNT 256 + +#define BLK_SNAP 'V' + +#pragma pack(push, 1) +////////////////////////////////////////////////////////////////////////// +// version
This is not normal comment style.
quoted hunk
+#define BLK_SNAP_COMPATIBILITY_SNAPSTORE 0x0000000000000001ull /* rudiment */ +//#define BLK_SNAP_COMPATIBILITY_BTRFS 0x0000000000000002ull /* rudiment */ +#define BLK_SNAP_COMPATIBILITY_MULTIDEV 0x0000000000000004ull
Don't comment out code. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek