# Re: \[PATCH V10 01/19\] block: introduce multi-page page bvec helpers

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2018-11-16 13:13:05 
- List: linux-block
- Page: https://ratatoskr.run/linux-block/2018/11/146401
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t.md

```text
> -#define bvec_iter_page(bvec, iter)				\
> +#define mp_bvec_iter_page(bvec, iter)				\
>  	(__bvec_iter_bvec((bvec), (iter))->bv_page)
>  
> -#define bvec_iter_len(bvec, iter)				\
> +#define mp_bvec_iter_len(bvec, iter)				\

I'd much prefer if we would stick to the segment naming that
we also use in the higher level helper.

So segment_iter_page, segment_iter_len, etc.

> + * This helpers are for building sp bvec in flight.

Please spell out single page, sp is not easy understandable.
```
