Thread (36 messages) 36 messages, 6 authors, 2017-06-30

Re: [PATCH v8 03/18] fs: check for writeback errors after syncing out buffers in generic_file_fsync

From: Jeff Layton <hidden>
Date: 2017-06-29 20:17:23
Also in: linux-btrfs, linux-ext4, linux-fsdevel, linux-mm, linux-xfs

On Thu, 2017-06-29 at 07:19 -0700, Christoph Hellwig wrote:
On Thu, Jun 29, 2017 at 09:19:39AM -0400, jlayton@kernel.org wrote:
quoted
From: Jeff Layton <redacted>

ext2 currently does a test+clear of the AS_EIO flag, which is
is problematic for some coming changes.

What we really need to do instead is call filemap_check_errors
in __generic_file_fsync after syncing out the buffers. That
will be sufficient for this case, and help other callers detect
these errors properly as well.

With that, we don't need to twiddle it in ext2.
Seems like much of this code is getting replaced later in the
series..

It does. I suppose I could squash this in with the __generic_file_fsync
patch.

-- 
Jeff Layton [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help