[bug report] blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods

From: Dan Carpenter <hidden>
Date: 2016-11-10 13:34:37

[ No idea why it's suddenly complaining about year old code - dan ]

Hello Tejun Heo,

The patch e4a9bde9589f: "blkcg: replace blkcg_policy->cpd_size with
->cpd_alloc/free_fn() methods" from Aug 18, 2015, leads to the
following static checker warning:

	block/cfq-iosched.c:1589 cfq_cpd_alloc()
	warn: use 'gfp' here instead of GFP_XXX?

block/cfq-iosched.c
  1585  static struct blkcg_policy_data *cfq_cpd_alloc(gfp_t gfp)
  1586  {
  1587          struct cfq_group_data *cgd;
  1588  
  1589          cgd = kzalloc(sizeof(*cgd), GFP_KERNEL);

It does feels weird to pass "gfp" and never use it.

  1590          if (!cgd)
  1591                  return NULL;
  1592          return &cgd->cpd;
  1593  }


regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help