[PATCH 13/60] fs: logfs: remove unnecesary check

Subsystems: filesystems (vfs and infrastructure), the rest

STALE3514d

Revision v1 of 2 in this series.

2 messages, 2 authors, 2016-10-31 · open the first message on its own page

[PATCH 13/60] fs: logfs: remove unnecesary check

From: Ming Lei <tom.leiming@gmail.com>
Date: 2016-10-29 08:12:55

The check on bio->bi_vcnt doesn't make sense in erase_end_io().

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 fs/logfs/dev_bdev.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c
index ff5e3e31bca3..f05a02ff43e6 100644
--- a/fs/logfs/dev_bdev.c
+++ b/fs/logfs/dev_bdev.c
@@ -144,7 +144,6 @@ static void erase_end_io(struct bio *bio)
 	struct logfs_super *super = logfs_super(sb); 
 
 	BUG_ON(bio->bi_error); /* FIXME: Retry io or write elsewhere */ 
-	BUG_ON(bio->bi_vcnt == 0); 
 	bio_put(bio); 
 	if (atomic_dec_and_test(&super->s_pending_writes))
 		wake_up(&wq); 
-- 
2.7.4

Re: [PATCH 13/60] fs: logfs: remove unnecesary check

From: Christoph Hellwig <hch@infradead.org>
Date: 2016-10-31 15:29:58

On Sat, Oct 29, 2016 at 04:08:12PM +0800, Ming Lei wrote:
The check on bio->bi_vcnt doesn't make sense in erase_end_io().
Agreed,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help