To ensure we aren't shooting ourselves in the foot after merge for
potentially doing future revisions for dirent or for storing multiple
names for casefolding, limit this to 512 for now.
Previously this define was linked to the max size a d_name in
bch_dirent could be.
Signed-off-by: Joshua Ashton <redacted>
---
fs/bcachefs/bcachefs_format.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Kent Overstreet <kent.overstreet@linux.dev> Date: 2023-08-13 15:10:44
On Sun, Aug 13, 2023 at 12:59:17AM +0100, Joshua Ashton wrote:
To ensure we aren't shooting ourselves in the foot after merge for
potentially doing future revisions for dirent or for storing multiple
names for casefolding, limit this to 512 for now.
Any time you're changing something - always grep to see how it's used:
bch2_dirent_invalid():
if (d_name.len > BCH_NAME_MAX) {
prt_printf(err, "dirent name too big (%u > %u)",
d_name.len, BCH_NAME_MAX);
return -BCH_ERR_invalid_bkey;
}
We'll need to either delete that check, or only run it for new keys
(flags & BKEY_INVALID_COMMIT), we don't want to be deleting existing
dirents
quoted hunk
Previously this define was linked to the max size a d_name in
bch_dirent could be.
Signed-off-by: Joshua Ashton <redacted>
---
fs/bcachefs/bcachefs_format.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
On Sun, Aug 13, 2023 at 12:59:17AM +0100, Joshua Ashton wrote:
quoted
To ensure we aren't shooting ourselves in the foot after merge for
potentially doing future revisions for dirent or for storing multiple
names for casefolding, limit this to 512 for now.
Any time you're changing something - always grep to see how it's used:
Was aware it was used here, but wasn't sure what you were willing to accept in terms of compat.
bch2_dirent_invalid():
if (d_name.len > BCH_NAME_MAX) {
prt_printf(err, "dirent name too big (%u > %u)",
d_name.len, BCH_NAME_MAX);
return -BCH_ERR_invalid_bkey;
}
We'll need to either delete that check, or only run it for new keys
(flags & BKEY_INVALID_COMMIT), we don't want to be deleting existing
dirents
It isn't actually possible for this check to even trigger with the old BCH_NAME_MAX given how the length was calculated and the value of it.
Makes sense to just change it to a check on COMMIT for new keys with the new size..
(Should also never happen, but makes sense for sanity.)
- Joshie 🐸✨
quoted
Previously this define was linked to the max size a d_name in
bch_dirent could be.
Signed-off-by: Joshua Ashton <redacted>
---
fs/bcachefs/bcachefs_format.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Kent Overstreet <kent.overstreet@linux.dev> Date: 2023-08-13 15:43:12
On Sun, Aug 13, 2023 at 04:29:52PM +0100, Joshua Ashton wrote:
On 8/13/23 16:10, Kent Overstreet wrote:
quoted
On Sun, Aug 13, 2023 at 12:59:17AM +0100, Joshua Ashton wrote:
quoted
To ensure we aren't shooting ourselves in the foot after merge for
potentially doing future revisions for dirent or for storing multiple
names for casefolding, limit this to 512 for now.
Any time you're changing something - always grep to see how it's used:
Was aware it was used here, but wasn't sure what you were willing to accept
in terms of compat.
Make sure to mention things you aren't sure about in the commit message
then, don't leave surprises :)
quoted
bch2_dirent_invalid():
if (d_name.len > BCH_NAME_MAX) {
prt_printf(err, "dirent name too big (%u > %u)",
d_name.len, BCH_NAME_MAX);
return -BCH_ERR_invalid_bkey;
}
We'll need to either delete that check, or only run it for new keys
(flags & BKEY_INVALID_COMMIT), we don't want to be deleting existing
dirents
It isn't actually possible for this check to even trigger with the old
BCH_NAME_MAX given how the length was calculated and the value of it.
Yes, but after your patch this check will trigger on any dirents longer
than the new BCH_NAME_MAX, and they'll be deleted.
Makes sense to just change it to a check on COMMIT for new keys with the new
size..
(Should also never happen, but makes sense for sanity.)
Yeah, that's what the .invalid() methods are for - catching bugs before
we write garbage out to disk.