# \[PATCH AUTOSEL 4.19 212/252\] bcache: cached\_dev\_free needs to put the sb page

- From: Sasha Levin \<sashal@kernel.org\>
- Date: 2020-02-14 16:17:09 
- List: linux-bcache
- Page: https://ratatoskr.run/linux-bcache/2020/02/5861995
- Thread: https://ratatoskr.run/stable/2020/02/5861938/t.md

```text
From: Liang Chen <redacted>

[ Upstream commit e8547d42095e58bee658f00fef8e33d2a185c927 ]

Same as cache device, the buffer page needs to be put while
freeing cached_dev.  Otherwise a page would be leaked every
time a cached_dev is stopped.

Signed-off-by: Liang Chen <redacted>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Coly Li <redacted>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/md/bcache/super.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index c45d9ad010770..5b5cbfadd003d 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1226,6 +1226,9 @@ static void cached_dev_free(struct closure *cl)
 
 	mutex_unlock(&bch_register_lock);
 
+	if (dc->sb_bio.bi_inline_vecs[0].bv_page)
+		put_page(bio_first_page_all(&dc->sb_bio));
+
 	if (!IS_ERR_OR_NULL(dc->bdev))
 		blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
 
-- 
2.20.1
```