Inter-revision diff: cover letter

Comparing v1 (message) to v2 (message)

--- v1
+++ v2
@@ -1,4 +1,14 @@
-Note: All changes to arch/x86 are contained within patches 01-02.
+Hi Greg,
+
+This is a second round of patches introducing PECI subsystem.
+I don't think it is ready to be applied right away (we're still
+missing r-b's), but I hope we have chance to complete discussion in
+the 5.15 development cycle. I would appreciate if you could take
+a look.
+
+Note: All changes to arch/x86 are contained within patches 01-02, plus
+small Kconfig change adding "depends on PECI" to GENERIC_LIB_X86
+Kconfig in patch 10.
 
 The Platform Environment Control Interface (PECI) is a communication
 interface between Intel processors and management controllers (e.g.
@@ -39,7 +49,42 @@
 [1] https://github.com/openbmc/openbmc
 [2] https://lore.kernel.org/openbmc/20191211194624.2872-1-jae.hyun.yoo at linux.intel.com/
 
-Iwona Winiarska (12):
+Changes v1 -> v2:
+
+Biggest changes when it comes to diffstat are locking in HWMON
+(I decided to clean things up a bit while adding it), switching to
+devres usage in more places and exposing sysfs interface in separate patch.
+
+* Moved extending X86 ARCHITECTURE MAINTAINERS earlier in series (Dan)
+* Removed "default n" for GENERIC_LIB_X86 (Dan)
+* Added vendor prefix for peci-aspeed specific properties (Rob)
+* Refactored PECI to use devres consistently (Dan)
+* Added missing sysfs documentation and excluded adding peci-sysfs to
+  separate patch (Dan)
+* Used module_init() instead of subsys_init() for peci module initialization (Dan)
+* Removed redundant struct peci_device member (Dan)
+* Improved PECI Kconfig help (Randy/Dan)
+* Fixed/removed log messages (Dan, Guenter)
+* Refactored peci-cputemp and peci-dimmtemp and added missing locks (Guenter)
+* Removed unused dev_set_drvdata() in peci-cputemp and peci-dimmtemp (Guenter)
+* Fixed used types, names, fixed broken and added additional comments
+  to peci-hwmon (Guenter, Zev)
+* Refactored peci-dimmtemp to not return -ETIMEDOUT (Guenter)
+* Added sanity check for min_peci_revision in peci-hwmon drivers (Zev)
+* Added assert for DIMM_NUMS_MAX and additional warning in peci-dimmtemp (Zev)
+* Fixed macro names in peci-aspeed (Zev)
+* Refactored peci-aspeed sanitizing properties to a single helper function (Zev)
+* Fixed peci_cpu_device_ids definition for Broadwell Xeon D (David)
+* Refactor peci_request to use a single allocation (Zev)
+* Used min_t() to improve code readability (Zev)
+* Added macro for PECI_RDENDPTCFG_MMIO_WR_LEN_BASE and fixed adev type
+  array name to more descriptive (Zev)
+* Fixed peci-hwmon commit-msg and documentation (Zev)
+
+Thanks
+-Iwona
+
+Iwona Winiarska (13):
   x86/cpu: Move intel-family to arch-independent headers
   x86/cpu: Extract cpuid helpers to arch-independent
   dt-bindings: Add generic bindings for PECI
@@ -47,6 +92,7 @@
   ARM: dts: aspeed: Add PECI controller nodes
   peci: Add core infrastructure
   peci: Add device detection
+  peci: Add sysfs interface for PECI bus
   peci: Add support for PECI device drivers
   peci: Add peci-cpu driver
   hwmon: peci: Add cputemp driver
@@ -57,21 +103,22 @@
   peci: Add peci-aspeed controller driver
   docs: hwmon: Document PECI drivers
 
- .../devicetree/bindings/peci/peci-aspeed.yaml | 111 ++++
- .../bindings/peci/peci-controller.yaml        |  28 +
+ Documentation/ABI/testing/sysfs-bus-peci      |  16 +
+ .../devicetree/bindings/peci/peci-aspeed.yaml | 109 ++++
+ .../bindings/peci/peci-controller.yaml        |  33 +
  Documentation/hwmon/index.rst                 |   2 +
- Documentation/hwmon/peci-cputemp.rst          |  93 ++++
- Documentation/hwmon/peci-dimmtemp.rst         |  58 ++
+ Documentation/hwmon/peci-cputemp.rst          |  90 +++
+ Documentation/hwmon/peci-dimmtemp.rst         |  57 ++
  Documentation/index.rst                       |   1 +
  Documentation/peci/index.rst                  |  16 +
  Documentation/peci/peci.rst                   |  48 ++
- MAINTAINERS                                   |  32 ++
+ MAINTAINERS                                   |  32 +
  arch/arm/boot/dts/aspeed-g4.dtsi              |  14 +
  arch/arm/boot/dts/aspeed-g5.dtsi              |  14 +
  arch/arm/boot/dts/aspeed-g6.dtsi              |  14 +
  arch/x86/Kconfig                              |   1 +
  arch/x86/include/asm/cpu.h                    |   3 -
- arch/x86/include/asm/intel-family.h           | 141 +----
+ arch/x86/include/asm/intel-family.h           | 141 +---
  arch/x86/include/asm/microcode.h              |   2 +-
  arch/x86/kvm/cpuid.h                          |   3 +-
  arch/x86/lib/Makefile                         |   2 +-
@@ -80,31 +127,32 @@
  drivers/edac/mce_amd.c                        |   3 +-
  drivers/hwmon/Kconfig                         |   2 +
  drivers/hwmon/Makefile                        |   1 +
- drivers/hwmon/peci/Kconfig                    |  31 ++
+ drivers/hwmon/peci/Kconfig                    |  31 +
  drivers/hwmon/peci/Makefile                   |   7 +
- drivers/hwmon/peci/common.h                   |  46 ++
- drivers/hwmon/peci/cputemp.c                  | 503 +++++++++++++++++
- drivers/hwmon/peci/dimmtemp.c                 | 508 ++++++++++++++++++
- drivers/peci/Kconfig                          |  36 ++
+ drivers/hwmon/peci/common.h                   |  58 ++
+ drivers/hwmon/peci/cputemp.c                  | 591 +++++++++++++++++
+ drivers/hwmon/peci/dimmtemp.c                 | 614 ++++++++++++++++++
+ drivers/peci/Kconfig                          |  37 ++
  drivers/peci/Makefile                         |  10 +
- drivers/peci/controller/Kconfig               |  12 +
+ drivers/peci/controller/Kconfig               |  16 +
  drivers/peci/controller/Makefile              |   3 +
- drivers/peci/controller/peci-aspeed.c         | 501 +++++++++++++++++
- drivers/peci/core.c                           | 224 ++++++++
- drivers/peci/cpu.c                            | 347 ++++++++++++
- drivers/peci/device.c                         | 211 ++++++++
- drivers/peci/internal.h                       | 137 +++++
- drivers/peci/request.c                        | 502 +++++++++++++++++
+ drivers/peci/controller/peci-aspeed.c         | 445 +++++++++++++
+ drivers/peci/core.c                           | 238 +++++++
+ drivers/peci/cpu.c                            | 344 ++++++++++
+ drivers/peci/device.c                         | 221 +++++++
+ drivers/peci/internal.h                       | 137 ++++
+ drivers/peci/request.c                        | 477 ++++++++++++++
  drivers/peci/sysfs.c                          |  82 +++
  include/linux/peci-cpu.h                      |  38 ++
- include/linux/peci.h                          |  93 ++++
+ include/linux/peci.h                          | 110 ++++
  include/linux/x86/cpu.h                       |   9 +
  include/linux/x86/intel-family.h              | 146 +++++
- lib/Kconfig                                   |   5 +
+ lib/Kconfig                                   |   4 +
  lib/Makefile                                  |   2 +
  lib/x86/Makefile                              |   3 +
  {arch/x86/lib => lib/x86}/cpu.c               |   2 +-
- 47 files changed, 3902 insertions(+), 149 deletions(-)
+ 48 files changed, 4084 insertions(+), 149 deletions(-)
+ create mode 100644 Documentation/ABI/testing/sysfs-bus-peci
  create mode 100644 Documentation/devicetree/bindings/peci/peci-aspeed.yaml
  create mode 100644 Documentation/devicetree/bindings/peci/peci-controller.yaml
  create mode 100644 Documentation/hwmon/peci-cputemp.rst
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help