Thread (16 messages) 16 messages, 4 authors, 2025-02-26

Re: [PATCH v1 3/3] soc: aspeed: lpc-pcc: Add PCC controller support

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-02-17 12:00:58
Also in: linux-arm-kernel, lkml

On 17/02/2025 12:48, Kevin Chen wrote:
+
+	pcc->mdev.parent = dev;
+	pcc->mdev.minor = MISC_DYNAMIC_MINOR;
+	pcc->mdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME,
+					pcc->mdev_id);
+	pcc->mdev.fops = &pcc_fops;
+	rc = misc_register(&pcc->mdev);
+	if (rc) {
+		dev_err(dev, "Couldn't register misc device\n");
+		goto err_free_kfifo;
+	}
You cannot expose user-space interfaces from SoC drivers. Use
appropriate subsystem for this with proper ABI documentation.

See:
https://lore.kernel.org/all/bc5118f2-8982-46ff-bc75-d0c71475e909@app.fastmail.com/ (local)
and more discussions on LKML

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help