--- v3
+++ v2
@@ -1,74 +1,35 @@
Hi,
-This is the v3 patch series for adding XDP support to stmmac driver.
+This is the v2 patch series for adding XDP support to stmmac driver.
-Summary of the changes in v3 (per feedback from Jakub Kicinski):-
+Summary of the changes in v2:
-4/6: Factor in XDP buffer header and tail adjustment by XDP prog.
+1/6: Move IRQ affinity hint from dwmac-intel.c into stmmac_main.c inside
+ stmmac_request_irq_multi_msi() and clear the IRQ affinity hint in
+ stmmac_free_irq().
+ Tested the patch with reloading the driver and confirmed that there
+ is kernel warning during free_irq().
-5/6: Added 'nq->trans_start = jiffies' to avoid TX time-out for XDP_TX.
+3/6: Fix build warning of unused variable found in
+ https://patchwork.hopto.org/static/nipa/457321/12170149/build_32bit/stderr
-6/6: Added 'nq->trans_start = jiffies' to avoid TX time-out for
- ndo_xdp_xmit.
+4/6: Fix build warnig of unused variable found by lkp
-I retested this patch series on all the test steps listed in v1 and the
-results look good as expected. I also used xdp_adjust_tail test app in
-samples/bpf for checking out XDP head and tail adjustment introduced in
-4/6 and the result below looks correct too.
+There is no other patch changes in v2 for 2/6, 5/6 and 6/6 and the summary
+for their changes are in v1 patch series:
- ########################################################################
+ https://patchwork.kernel.org/project/netdevbpf/list/?series=457321
-DUT > root@intel-corei7-64:~ $ ./xdp_adjust_tail -i eth0 -P 400 -N
-==========================
-icmp "packet too big" sent: 0 pkts
-icmp "packet too big" sent: 0 pkts
-icmp "packet too big" sent: 0 pkts
-icmp "packet too big" sent: 0 pkts
-icmp "packet too big" sent: 1 pkts
-icmp "packet too big" sent: 1 pkts
-icmp "packet too big" sent: 1 pkts
-icmp "packet too big" sent: 2 pkts
-icmp "packet too big" sent: 4 pkts
-icmp "packet too big" sent: 6 pkts
-icmp "packet too big" sent: 8 pkts
-icmp "packet too big" sent: 9 pkts
-icmp "packet too big" sent: 10 pkts
-icmp "packet too big" sent: 10 pkts
+The v2 patch series are retested with the test steps listed in v1 and
+the results looks good as per v1 patch series. The test are executed with
+preempt-rt build and it also requires a fix that was sent to ML here:
-LP > root@intel-corei7-64:~# ping 169.254.1.11 -s 300
-PING 169.254.1.11 (169.254.1.11) 300(328) bytes of data.
-308 bytes from 169.254.1.11: icmp_seq=1 ttl=64 time=1.17 ms
-308 bytes from 169.254.1.11: icmp_seq=2 ttl=64 time=0.575 ms
-308 bytes from 169.254.1.11: icmp_seq=3 ttl=64 time=0.582 ms
-308 bytes from 169.254.1.11: icmp_seq=4 ttl=64 time=0.595 ms
-308 bytes from 169.254.1.11: icmp_seq=5 ttl=64 time=0.585 ms
-308 bytes from 169.254.1.11: icmp_seq=6 ttl=64 time=0.591 ms
-308 bytes from 169.254.1.11: icmp_seq=7 ttl=64 time=0.599 ms
-^C
---- 169.254.1.11 ping statistics ---
-7 packets transmitted, 7 received, 0% packet loss, time 6103ms
-rtt min/avg/max/mdev = 0.575/0.670/1.166/0.202 ms
+ https://patchwork.kernel.org/project/netdevbpf/list/?series=457139
-LP > root@intel-corei7-64:~# ping 169.254.1.11 -s 500
-PING 169.254.1.11 (169.254.1.11) 500(528) bytes of data.
-From 169.254.1.11 icmp_seq=1 Frag needed and DF set (mtu = 436)
-From 169.254.1.11 icmp_seq=2 Frag needed and DF set (mtu = 436)
-From 169.254.1.11 icmp_seq=3 Frag needed and DF set (mtu = 436)
-From 169.254.1.11 icmp_seq=4 Frag needed and DF set (mtu = 436)
-From 169.254.1.11 icmp_seq=5 Frag needed and DF set (mtu = 436)
-From 169.254.1.11 icmp_seq=6 Frag needed and DF set (mtu = 436)
+It will be great if community help test out these v2 patch series on your
+platform and provide me feedback.
- ########################################################################
-
-History of the previous patch series:
-
-v2: https://patchwork.kernel.org/project/netdevbpf/list/?series=457757
-v1: https://patchwork.kernel.org/project/netdevbpf/list/?series=457139
-
-It will be great if community can help to test or review the v3 patch
-series on your platform and provide me any new feedback if any.
-
-Thank you very much.
+Thank you very much,
Boon Leong
Ong Boon Leong (6):
@@ -82,10 +43,10 @@
drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 35 +-
- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 529 +++++++++++++++---
+ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 521 +++++++++++++++---
.../net/ethernet/stmicro/stmmac/stmmac_xdp.c | 40 ++
.../net/ethernet/stmicro/stmmac/stmmac_xdp.h | 12 +
- 5 files changed, 537 insertions(+), 80 deletions(-)
+ 5 files changed, 530 insertions(+), 79 deletions(-)
create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.c
create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.h