[PATCH 0/5] Fix dtbs_check warnings for MediaTek MT7622 platform

STALE190d

13 messages, 5 authors, 2026-01-23 · open the first message on its own page

[PATCH 0/5] Fix dtbs_check warnings for MediaTek MT7622 platform

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-01-13 11:00:16

This series fixes various dtbs_check warnings happening on the MediaTek
MT7622 Home Router platforms devicetrees.

Depending on correctness, either the bindings or the devicetree was
changed as a dtbs_check warning fix.

AngeloGioacchino Del Regno (5):
  dt-bindings: clock: mediatek,mt7622-pciesys: Remove syscon compatible
  dt-bindings: power: mt7622-power: Add MT7622_POWER_DOMAIN_AUDIO
  pmdomain: mediatek: scpsys: Add MT7622 Audio power domain to legacy
    driver
  arm64: dts: mediatek: mt7622: Add missing clock to audio-controller
  arm64: dts: mediatek: mt7622: Add missing power domain to afe

 .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++------
 arch/arm64/boot/dts/mediatek/mt7622.dtsi               |  7 +++++--
 drivers/pmdomain/mediatek/mtk-scpsys.c                 | 10 ++++++++++
 include/dt-bindings/power/mt7622-power.h               |  1 +
 4 files changed, 20 insertions(+), 8 deletions(-)

-- 
2.52.0

[PATCH 1/5] dt-bindings: clock: mediatek,mt7622-pciesys: Remove syscon compatible

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-01-13 11:00:16

The PCIESYS register space contains a pure clock controller, which
has no system controller register, so this definitely doesn't need
any "syscon" compatible.

As a side note, luckily no devicetree ever added the syscon string
to PCIESYS clock controller node compatibles, so this also resolves
a dtbs_check warning for mt7622.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
index 9c3913f9092c..c77111d10f90 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml

@@ -14,11 +14,9 @@ maintainers:
 
 properties:
   compatible:
-    oneOf:
-      - items:
-          - const: mediatek,mt7622-pciesys
-          - const: syscon
-      - const: mediatek,mt7629-pciesys
+    enum:
+      - mediatek,mt7622-pciesys
+      - mediatek,mt7629-pciesys
 
   reg:
     maxItems: 1

@@ -40,7 +38,7 @@ additionalProperties: false
 examples:
   - |
     clock-controller@1a100800 {
-        compatible = "mediatek,mt7622-pciesys", "syscon";
+        compatible = "mediatek,mt7622-pciesys";
         reg = <0x1a100800 0x1000>;
         #clock-cells = <1>;
         #reset-cells = <1>;

-- 
2.52.0

Re: [PATCH 1/5] dt-bindings: clock: mediatek,mt7622-pciesys: Remove syscon compatible

From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2026-01-13 21:34:56

On Tue, 13 Jan 2026 12:00:08 +0100, AngeloGioacchino Del Regno wrote:

The PCIESYS register space contains a pure clock controller, which
has no system controller register, so this definitely doesn't need
any "syscon" compatible.

As a side note, luckily no devicetree ever added the syscon string
to PCIESYS clock controller node compatibles, so this also resolves
a dtbs_check warning for mt7622.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/5] dt-bindings: clock: mediatek,mt7622-pciesys: Remove syscon compatible

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2026-01-14 08:17:03

On 13/1/26 12:00, AngeloGioacchino Del Regno wrote:

The PCIESYS register space contains a pure clock controller, which
has no system controller register, so this definitely doesn't need
any "syscon" compatible.

As a side note, luckily no devicetree ever added the syscon string
to PCIESYS clock controller node compatibles, so this also resolves
a dtbs_check warning for mt7622.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

quoted hunk

---
  .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
index 9c3913f9092c..c77111d10f90 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml

@@ -14,11 +14,9 @@ maintainers:
  
  properties:
    compatible:
-    oneOf:
-      - items:
-          - const: mediatek,mt7622-pciesys
-          - const: syscon
-      - const: mediatek,mt7629-pciesys
+    enum:
+      - mediatek,mt7622-pciesys
+      - mediatek,mt7629-pciesys
  
    reg:
      maxItems: 1

@@ -40,7 +38,7 @@ additionalProperties: false
  examples:
    - |
      clock-controller@1a100800 {
-        compatible = "mediatek,mt7622-pciesys", "syscon";
+        compatible = "mediatek,mt7622-pciesys";
          reg = <0x1a100800 0x1000>;
          #clock-cells = <1>;
          #reset-cells = <1>;

Re: [PATCH 1/5] dt-bindings: clock: mediatek,mt7622-pciesys: Remove syscon compatible

From: Stephen Boyd <sboyd@kernel.org>
Date: 2026-01-23 01:44:05

Quoting AngeloGioacchino Del Regno (2026-01-13 04:00:08)

The PCIESYS register space contains a pure clock controller, which
has no system controller register, so this definitely doesn't need
any "syscon" compatible.

As a side note, luckily no devicetree ever added the syscon string
to PCIESYS clock controller node compatibles, so this also resolves
a dtbs_check warning for mt7622.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---

Applied to clk-next

[PATCH 2/5] dt-bindings: power: mt7622-power: Add MT7622_POWER_DOMAIN_AUDIO

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-01-13 11:00:17

Add the missing power domain for the Audio IPs in this SoC.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 include/dt-bindings/power/mt7622-power.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/power/mt7622-power.h b/include/dt-bindings/power/mt7622-power.h
index ffad81ad3d46..ec244989eeba 100644
--- a/include/dt-bindings/power/mt7622-power.h
+++ b/include/dt-bindings/power/mt7622-power.h

@@ -10,5 +10,6 @@
 #define MT7622_POWER_DOMAIN_HIF0	1
 #define MT7622_POWER_DOMAIN_HIF1	2
 #define MT7622_POWER_DOMAIN_WB		3
+#define MT7622_POWER_DOMAIN_AUDIO	4
 
 #endif /* _DT_BINDINGS_POWER_MT7622_POWER_H */

-- 
2.52.0

Re: [PATCH 2/5] dt-bindings: power: mt7622-power: Add MT7622_POWER_DOMAIN_AUDIO

From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2026-01-13 21:34:21

On Tue, 13 Jan 2026 12:00:09 +0100, AngeloGioacchino Del Regno wrote:

Add the missing power domain for the Audio IPs in this SoC.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 include/dt-bindings/power/mt7622-power.h | 1 +
 1 file changed, 1 insertion(+)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 3/5] pmdomain: mediatek: scpsys: Add MT7622 Audio power domain to legacy driver

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-01-13 11:00:18

Add the Audio power domain of the MT7622 SoC to the legacy
mtk-scpsys driver (as this legacy SoC is supported only there).

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/pmdomain/mediatek/mtk-scpsys.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/pmdomain/mediatek/mtk-scpsys.c b/drivers/pmdomain/mediatek/mtk-scpsys.c
index 1a80c1537a43..efc8f276ffce 100644
--- a/drivers/pmdomain/mediatek/mtk-scpsys.c
+++ b/drivers/pmdomain/mediatek/mtk-scpsys.c

@@ -867,6 +867,16 @@ static const struct scp_domain_data scp_domain_data_mt7622[] = {
 		.bus_prot_mask = MT7622_TOP_AXI_PROT_EN_WB,
 		.caps = MTK_SCPD_ACTIVE_WAKEUP | MTK_SCPD_FWAIT_SRAM,
 	},
+	[MT7622_POWER_DOMAIN_AUDIO] = {
+		.name = "audsys",
+		.sta_mask = PWR_STATUS_AUDIO,
+		.ctl_offs = SPM_AUDIO_PWR_CON,
+		.sram_pdn_bits = GENMASK(11, 8),
+		.sram_pdn_ack_bits = GENMASK(15, 12),
+		.clk_id = {CLK_NONE},
+		.bus_prot_mask = MT7622_TOP_AXI_PROT_EN_HIF1,
+		.caps = MTK_SCPD_ACTIVE_WAKEUP,
+	},
 };
 
 /*

-- 
2.52.0

[PATCH 4/5] arm64: dts: mediatek: mt7622: Add missing clock to audio-controller

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-01-13 11:00:19

Add the missing audio_mrgif_pd clock to the audio-controller node
to both resolve a dtbs_check warning and ensure that the AFE merge
interface is clocked while using audio.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 158bd9a305d7..133a6dcc8ef7 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi

@@ -654,7 +654,8 @@ afe: audio-controller {
 				 <&audsys CLK_AUDIO_AFE>,
 				 <&audsys CLK_AUDIO_AFE_CONN>,
 				 <&audsys CLK_AUDIO_A1SYS>,
-				 <&audsys CLK_AUDIO_A2SYS>;
+				 <&audsys CLK_AUDIO_A2SYS>,
+				 <&audsys CLK_AUDIO_AFE_MRGIF>;
 
 			clock-names = "infra_sys_audio_clk",
 				      "top_audio_mux1_sel",

@@ -688,7 +689,8 @@ afe: audio-controller {
 				      "audio_afe_pd",
 				      "audio_afe_conn_pd",
 				      "audio_a1sys_pd",
-				      "audio_a2sys_pd";
+				      "audio_a2sys_pd",
+				      "audio_mrgif_pd";
 
 			assigned-clocks = <&topckgen CLK_TOP_A1SYS_HP_SEL>,
 					  <&topckgen CLK_TOP_A2SYS_HP_SEL>,

-- 
2.52.0

Re: [PATCH 4/5] arm64: dts: mediatek: mt7622: Add missing clock to audio-controller

From: Rob Herring <robh@kernel.org>
Date: 2026-01-21 18:44:39

On Tue, Jan 13, 2026 at 12:00:11PM +0100, AngeloGioacchino Del Regno wrote:

Add the missing audio_mrgif_pd clock to the audio-controller node
to both resolve a dtbs_check warning and ensure that the AFE merge
interface is clocked while using audio.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH 5/5] arm64: dts: mediatek: mt7622: Add missing power domain to afe

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-01-13 11:00:20

Add the missing MT7622_POWER_DOMAIN_AUDIO to the audio controller
node to fix a dtbs_check warning and to make sure that the AFE is
indeed powered on when needed.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 133a6dcc8ef7..bfd96a0ec3dd 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi

@@ -621,6 +621,7 @@ afe: audio-controller {
 			interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_LOW>,
 				     <GIC_SPI 145 IRQ_TYPE_LEVEL_LOW>;
 			interrupt-names = "afe", "asys";
+			power-domains = <&scpsys MT7622_POWER_DOMAIN_AUDIO>;
 
 			clocks = <&infracfg CLK_INFRA_AUDIO_PD>,
 				 <&topckgen CLK_TOP_AUD1_SEL>,

-- 
2.52.0

Re: [PATCH 5/5] arm64: dts: mediatek: mt7622: Add missing power domain to afe

From: Rob Herring <robh@kernel.org>
Date: 2026-01-21 18:44:50

On Tue, Jan 13, 2026 at 12:00:12PM +0100, AngeloGioacchino Del Regno wrote:

Add the missing MT7622_POWER_DOMAIN_AUDIO to the audio controller
node to fix a dtbs_check warning and to make sure that the AFE is
indeed powered on when needed.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
 1 file changed, 1 insertion(+)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 0/5] Fix dtbs_check warnings for MediaTek MT7622 platform

From: Ulf Hansson <hidden>
Date: 2026-01-15 16:24:30

On Tue, 13 Jan 2026 at 12:00, AngeloGioacchino Del Regno
[off-list ref] wrote:

This series fixes various dtbs_check warnings happening on the MediaTek
MT7622 Home Router platforms devicetrees.

Depending on correctness, either the bindings or the devicetree was
changed as a dtbs_check warning fix.

AngeloGioacchino Del Regno (5):
  dt-bindings: clock: mediatek,mt7622-pciesys: Remove syscon compatible
  dt-bindings: power: mt7622-power: Add MT7622_POWER_DOMAIN_AUDIO
  pmdomain: mediatek: scpsys: Add MT7622 Audio power domain to legacy
    driver
  arm64: dts: mediatek: mt7622: Add missing clock to audio-controller
  arm64: dts: mediatek: mt7622: Add missing power domain to afe

 .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++------
 arch/arm64/boot/dts/mediatek/mt7622.dtsi               |  7 +++++--
 drivers/pmdomain/mediatek/mtk-scpsys.c                 | 10 ++++++++++
 include/dt-bindings/power/mt7622-power.h               |  1 +
 4 files changed, 20 insertions(+), 8 deletions(-)

--
2.52.0

Patch 2 and 3 applied for next, thanks!

Note, the DT patch (patch2) is also available at the immutable dt
branch, for soc maintainers to pull in.

Kind regards
Uffe

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help