[PATCH] serial: 8250_mtk: correct max baud rate in the set_termios() method
From: Sergey Shtylyov <hidden>
Date: 2025-09-05 20:07:16
Also in:
linux-mediatek, linux-serial, lkml
From: Sergey Shtylyov <hidden>
Date: 2025-09-05 20:07:16
Also in:
linux-mediatek, linux-serial, lkml
As is obvious from the code calculating the divisor in the set_termios()
method, the Mediatek UART driver uses 256-time oversampling for the high
baud rates, so passing port->uartclk to uart_get_baud_rate() for the max
acceptable baud rate makes no sense, we should divide by 256 first (this
should also prevent overflow when some arbitrary baud rate is passed via
termios->c_ospeed)...
Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.
Fixes: 81bb549fdf14 ("serial: 8250_mtk: support big baud rate.")
Signed-off-by: Sergey Shtylyov <redacted>
---
The patch is against the master branch of Linus Torvalds' linux.git repo.
drivers/tty/serial/8250/8250_mtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/tty/serial/8250/8250_mtk.c
===================================================================--- linux.orig/drivers/tty/serial/8250/8250_mtk.c
+++ linux/drivers/tty/serial/8250/8250_mtk.c@@ -358,7 +358,7 @@ mtk8250_set_termios(struct uart_port *po */ baud = uart_get_baud_rate(port, termios, old, port->uartclk / 16 / UART_DIV_MAX, - port->uartclk); + port->uartclk / 256); if (baud < 115200) { serial_port_out(port, MTK_UART_HIGHS, 0x0);