[EXTERNAL] [PATCH] irqchip/mvebu-gicp: Fix an IS_ERR() vs NULL check in probe()The ioremap() function never returns error pointers, it returns NULLd
From: Elad Nachman <enachman@marvell.com>
Date: 2025-08-19 12:06:08
Also in:
kernel-janitors, lkml
Acked-by: Elad Nachman <enachman@marvell.com>
quoted hunk
The ioremap() function never returns error pointers, it returns NULL on error. Fix the checking to match. Fixes: 3c3d7dbab2c7 ("irqchip/mvebu-gicp: Clear pending interrupts on init") Signed-off-by: Dan Carpenter <redacted> --- drivers/irqchip/irq-mvebu-gicp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c index 54833717f8a7..667bde3c651f 100644 --- a/drivers/irqchip/irq-mvebu-gicp.c +++ b/drivers/irqchip/irq-mvebu-gicp.c@@ -238,7 +238,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)} base = ioremap(gicp->res->start, resource_size(gicp->res)); - if (IS_ERR(base)) { + if (!base) { dev_err(&pdev->dev, "ioremap() failed. Unable to clear pending interrupts.\n"); } else { for (i = 0; i < 64; i++) -- 2.47.2