[PATCH v4 03/15] pinctrl: airoha: replace struct function_desc with struct pinfunction
From: Bartosz Golaszewski <hidden>
Date: 2025-08-12 08:27:15
Also in:
imx, linux-arm-msm, linux-gpio, linux-hardening, linux-mediatek, linux-mips, linux-mm, linux-omap, linux-renesas-soc, lkml
Subsystem:
pin control subsystem, pin controller - airoha, pin controller - mediatek, the rest · Maintainers:
Linus Walleij, Lorenzo Bianconi, Sean Wang, Linus Torvalds
From: Bartosz Golaszewski <redacted> struct function_desc is a wrapper around struct pinfunction with an additional void *data pointer. This driver doesn't use the data pointer. We're also working towards reducing the usage of struct function_desc in pinctrl drivers - they should only be created by pinmux core and accessed by drivers using pinmux_generic_get_function(). Replace the struct function_desc objects in this driver with smaller struct pinfunction instances. Signed-off-by: Bartosz Golaszewski <redacted> --- drivers/pinctrl/mediatek/pinctrl-airoha.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
index 5f1ec9e0de213d587b68f41d3458cf504ee1b21f..51cd0cdc2f5170d024fe984ce8882ed9b3ce6563 100644
--- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
+++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c@@ -36,11 +36,9 @@ #define PINCTRL_FUNC_DESC(id) \ { \ .desc = { \ - .func = { \ - .name = #id, \ - .groups = id##_groups, \ - .ngroups = ARRAY_SIZE(id##_groups), \ - } \ + .name = #id, \ + .groups = id##_groups, \ + .ngroups = ARRAY_SIZE(id##_groups), \ }, \ .groups = id##_func_group, \ .group_size = ARRAY_SIZE(id##_func_group), \
@@ -334,7 +332,7 @@ struct airoha_pinctrl_func_group { }; struct airoha_pinctrl_func { - const struct function_desc desc; + const struct pinfunction desc; const struct airoha_pinctrl_func_group *groups; u8 group_size; };
@@ -2908,11 +2906,11 @@ static int airoha_pinctrl_probe(struct platform_device *pdev) func = &airoha_pinctrl_funcs[i]; err = pinmux_generic_add_pinfunction(pinctrl->ctrl, - &func->desc.func, + &func->desc, (void *)func); if (err < 0) { dev_err(dev, "Failed to register function %s\n", - func->desc.func.name); + func->desc.name); return err; } }
--
2.48.1