[PATCH v3] arm: s3c: use string choices helper

Subsystems: arm port, arm/samsung s3c, s5p and exynos arm architectures, the rest

STALE408d

2 messages, 2 authors, 2025-06-19 · open the first message on its own page

[PATCH v3] arm: s3c: use string choices helper

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: 2025-06-18 23:04:38

We can use string choices helper, let's use it.
It also tidyup printk(KERN_INFO, ...) to pr_info(...).

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v2 -> v3
	- use pr_info()

v1 -> v2
	- add commit message

 arch/arm/mach-s3c/pm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c/pm.c b/arch/arm/mach-s3c/pm.c
index 5698cbceaf7a..e4c240699d14 100644
--- a/arch/arm/mach-s3c/pm.c
+++ b/arch/arm/mach-s3c/pm.c
@@ -46,8 +46,7 @@ int s3c_irqext_wake(struct irq_data *data, unsigned int state)
 	if (!(s3c_irqwake_eintallow & bit))
 		return -ENOENT;
 
-	printk(KERN_INFO "wake %s for irq %d\n",
-	       state ? "enabled" : "disabled", data->irq);
+	pr_info("wake %s for irq %d\n", str_enabled_disabled(state), data->irq);
 
 	if (!state)
 		s3c_irqwake_eintmask |= bit;
-- 
2.43.0

Re: [PATCH v3] arm: s3c: use string choices helper

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-06-19 06:21:23

On 19/06/2025 01:01, Kuninori Morimoto wrote:
We can use string choices helper, let's use it.
It also tidyup printk(KERN_INFO, ...) to pr_info(...).
Why? Considering what I wrote, I don't see point in this. You keep
sending the same completely missing my point.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help