[PATCH v2] media: raspberrypi: cfe: Fix mapping of dmabuf buffers
DORMANTno replies
REVIEWED: 1 (1M)
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Date: 2024-11-04 07:48:22
Also in:
linux-media, lkml
Subsystem:
media input infrastructure (v4l/dvb), raspberry pi pisp camera front end, the rest · Maintainers:
Mauro Carvalho Chehab, Tomi Valkeinen, Raspberry Pi Kernel Maintenance, Linus Torvalds
1 review trailer.
When using buffers from DRM, DMA-API gives a warning about: "mapping sg
segment longer than device claims to support [len=307200] [max=65536]"
Add a call to vb2_dma_contig_set_max_seg_size() to tell the DMA-API
about the supported segment size (which is UINT_MAX).
Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
Changes in v2:
- Drop the error print, as vb2_dma_contig_set_max_seg_size() already
prints one.
- Link to v1: https://lore.kernel.org/r/20241101-rp1-cfe-fixes-seg-size-v1-1-0aacf2da56e5@ideasonboard.com (local)
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index da9e1a1e4d0d..e808c80cd37c 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c@@ -2341,6 +2341,10 @@ static int cfe_probe(struct platform_device *pdev) goto err_cfe_put; } + ret = vb2_dma_contig_set_max_seg_size(&pdev->dev, UINT_MAX); + if (ret) + goto err_cfe_put; + /* TODO: Enable clock only when running. */ cfe->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(cfe->clk))
--- base-commit: c7ccf3683ac9746b263b0502255f5ce47f64fe0a change-id: 20241101-rp1-cfe-fixes-seg-size-b70309da74a2 Best regards, -- Tomi Valkeinen [off-list ref]