[PATCH] gpio: gpio-davinci: Fix condition for irqchip registration

Subsystems: gpio subsystem, the rest, ti davinci series gpio driver

STALE747d LANDED

Landed in mainline as 5a431e50e9d4 on 2024-10-02.

2 messages, 2 authors, 2024-10-02 · open the first message on its own page

[PATCH] gpio: gpio-davinci: Fix condition for irqchip registration

From: Vignesh Raghavendra <vigneshr@ti.com>
Date: 2024-10-02 07:19:29

Since commit d29e741cad3f ("gpio: davinci: drop platform data support"),
irqchip is no longer being registered on platforms what don't use
unbanked gpios. Fix this.

Reported-by: Sabeeh Khan <redacted>
Fixes: d29e741cad3f ("gpio: davinci: drop platform data support")
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 drivers/gpio/gpio-davinci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 790595f3b949..76b58c70b257 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 		return PTR_ERR(clk);
 	}
 
-	if (chips->gpio_unbanked) {
+	if (!chips->gpio_unbanked) {
 		irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);
 		if (irq < 0) {
 			dev_err(dev, "Couldn't allocate IRQ numbers\n");
-- 
2.46.2

Re: [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration

From: Bartosz Golaszewski <hidden>
Date: 2024-10-02 10:24:32

From: Bartosz Golaszewski <redacted>


On Wed, 02 Oct 2024 12:49:01 +0530, Vignesh Raghavendra wrote:
Since commit d29e741cad3f ("gpio: davinci: drop platform data support"),
irqchip is no longer being registered on platforms what don't use
unbanked gpios. Fix this.
My bad, thanks for spotting this.

Applied, thanks!

[1/1] gpio: gpio-davinci: Fix condition for irqchip registration
      commit: 69e40c3ef27998105b3002434ee640800d376668

Best regards,
-- 
Bartosz Golaszewski [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help