[arm-platforms:kvm-arm64/asahi-base-6.11 23/29] drivers/tty/serial/samsung_tty.c:2085:9: warning: this 'if' clause does not guard...

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git kvm-arm64/asahi-base-6.11
head:   0619e126e13837cf7e2cc8dfda13d762d37dc10a
commit: ce041b76229de01c9de3bd890e2710b59f23bf1c [23/29] Revert "fixup! tty: serial: samsung_tty: Support runtime PM"
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240911/202409111813.9z0YpifN-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409111813.9z0YpifN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202409111813.9z0YpifN-lkp@intel.com/ (local)

All warnings (new ones prefixed by >>):

   drivers/tty/serial/samsung_tty.c: In function 's3c24xx_serial_remove':

quoted

drivers/tty/serial/samsung_tty.c:2085:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]

    2085 |         if (port)
         |         ^~
   drivers/tty/serial/samsung_tty.c:2087:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    2087 |                 uart_remove_one_port(&s3c24xx_uart_drv, port);
         |                 ^~~~~~~~~~~~~~~~~~~~


vim +/if +2085 drivers/tty/serial/samsung_tty.c

  2079	
  2080	static void s3c24xx_serial_remove(struct platform_device *dev)
  2081	{
  2082		struct uart_port *port = s3c24xx_dev_to_port(&dev->dev);
  2083		struct s3c24xx_uart_port *ourport = to_ourport(port);
  2084	

2085		if (port)

  2086			pm_runtime_get_sync(&dev->dev);
  2087			uart_remove_one_port(&s3c24xx_uart_drv, port);
  2088	
  2089			clk_disable_unprepare(ourport->clk);
  2090			if (!IS_ERR(ourport->baudclk))
  2091				clk_disable_unprepare(ourport->baudclk);
  2092	
  2093			pm_runtime_disable(&dev->dev);
  2094			pm_runtime_set_suspended(&dev->dev);
  2095			pm_runtime_put_noidle(&dev->dev);
  2096	
  2097		uart_unregister_driver(&s3c24xx_uart_drv);
  2098	}
  2099	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki