[PATCH -next 2/8] pmdomain: Make apple_pmgr_reset_ops static

Subsystems: arm/apple machine support, generic pm domains, the rest

STALE718d LANDED

Landed in mainline as 9b37f971f313 on 2024-08-20.

2 messages, 2 authors, 2024-08-20 · open the first message on its own page

[PATCH -next 2/8] pmdomain: Make apple_pmgr_reset_ops static

From: Jinjie Ruan <hidden>
Date: 2024-08-19 11:52:38

The sparse tool complains as follows:

drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: warning:
	symbol 'apple_pmgr_reset_ops' was not declared. Should it be static:

This symbol is not used outside of pmgr-pwrstate.c, so marks it static.

Signed-off-by: Jinjie Ruan <redacted>
---
 drivers/pmdomain/apple/pmgr-pwrstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pmdomain/apple/pmgr-pwrstate.c b/drivers/pmdomain/apple/pmgr-pwrstate.c
index d62a776c89a1..9467235110f4 100644
--- a/drivers/pmdomain/apple/pmgr-pwrstate.c
+++ b/drivers/pmdomain/apple/pmgr-pwrstate.c
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
 	return !!(reg & APPLE_PMGR_RESET);
 }
 
-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
 	.assert		= apple_pmgr_reset_assert,
 	.deassert	= apple_pmgr_reset_deassert,
 	.reset		= apple_pmgr_reset_reset,
-- 
2.34.1

Re: [PATCH -next 2/8] pmdomain: Make apple_pmgr_reset_ops static

From: Ulf Hansson <hidden>
Date: 2024-08-20 09:34:31

On Mon, 19 Aug 2024 at 13:52, Jinjie Ruan [off-list ref] wrote:
The sparse tool complains as follows:

drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: warning:
        symbol 'apple_pmgr_reset_ops' was not declared. Should it be static:

This symbol is not used outside of pmgr-pwrstate.c, so marks it static.

Signed-off-by: Jinjie Ruan <redacted>
Applied for next, thanks!

Kind regards
Uffe

quoted hunk
---
 drivers/pmdomain/apple/pmgr-pwrstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pmdomain/apple/pmgr-pwrstate.c b/drivers/pmdomain/apple/pmgr-pwrstate.c
index d62a776c89a1..9467235110f4 100644
--- a/drivers/pmdomain/apple/pmgr-pwrstate.c
+++ b/drivers/pmdomain/apple/pmgr-pwrstate.c
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
        return !!(reg & APPLE_PMGR_RESET);
 }

-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
        .assert         = apple_pmgr_reset_assert,
        .deassert       = apple_pmgr_reset_deassert,
        .reset          = apple_pmgr_reset_reset,
--
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help