[PATCH RFC 07/37] mm: page_alloc: Bypass pcp when freeing MIGRATE_METADATA pages
From: Alexandru Elisei <hidden>
Date: 2023-08-23 13:15:19
Also in:
kvmarm, linux-arch, linux-fsdevel, linux-mm, linux-trace-kernel, lkml
Subsystem:
memory management, memory management - page allocator, the rest · Maintainers:
Andrew Morton, Vlastimil Babka, Linus Torvalds
When a metadata page is returned to the page allocator because all the associated pages with metadata were freed, the page will be returned to the pcp list, which makes it very likely that it will be used to satisfy an allocation request. This is not optimal, because metadata pages should be used as a last resort, to increase the chances they are not in use when they are needed, to avoid costly page migration. Bypass the pcp lists when freeing metadata pages. Note that metadata pages can still end up on the pcp lists when a list is refilled, but this should only happen when memory is running low, which is as intended Signed-off-by: Alexandru Elisei <redacted> --- mm/page_alloc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a693e23c4733..bbb49b489230 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c@@ -2478,7 +2478,8 @@ void free_unref_page(struct page *page, unsigned int order) */ migratetype = get_pcppage_migratetype(page); if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { - if (unlikely(is_migrate_isolate(migratetype))) { + if (unlikely(is_migrate_isolate(migratetype) || + is_migrate_metadata(migratetype))) { free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE); return; }
@@ -2522,7 +2523,8 @@ void free_unref_page_list(struct list_head *list) * comment in free_unref_page. */ migratetype = get_pcppage_migratetype(page); - if (unlikely(is_migrate_isolate(migratetype))) { + if (unlikely(is_migrate_isolate(migratetype) || + is_migrate_metadata(migratetype))) { list_del(&page->lru); free_one_page(page_zone(page), page, pfn, 0, migratetype, FPI_NONE); continue;
--
2.41.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel