This patch series is aimed at addressing several dtbs_check warnings by
introducing additional support in the device tree bindings for i.MX6
series SoCs. The warnings surfaced while validating some i.MX6 boards.
The issues were predominantly around unrecognized compatibility strings
and missing properties in the device trees.
Oleksij Rempel (7):
dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support
dt-bindings: timer: gpt: Add i.MX6UL support
dt-bindings: timer: gpt: Support 3rd clock for i.MX6DL
dt-bindings: crypto: fsl-dcp: Add i.MX6SL, i.MX6SLL, and i.MX6ULL
support
dt-bindings: clock: imx6ul: Support optional enet*_ref_pad clocks
dt-bindings: clock: imx6q: Allow single optional clock and add
enet_ref_pad
dt-bindings: input: touchscreen: edt-ft5x06: Add 'threshold' property
.../bindings/clock/imx6q-clock.yaml | 15 ++++++-----
.../bindings/clock/imx6ul-clock.yaml | 6 +++++
.../devicetree/bindings/crypto/fsl-dcp.yaml | 19 +++++++++++---
.../input/touchscreen/edt-ft5x06.yaml | 6 +++++
.../bindings/mmc/fsl-imx-esdhc.yaml | 2 ++
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 26 ++++++++++++++-----
6 files changed, 59 insertions(+), 15 deletions(-)
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
All clocks for this driver are optional, so this change allows the
'clocks' and 'clock-names' properties to accept a single clock.
Additionally, 'enet_ref_pad' clock is added. This resolves the following
dtbs_check warning:
imx6dl-alti6p.dtb: clock-controller@20c4000: clocks: [[24]] is too short
From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:0: 'osc' was
expected
From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:
['enet_ref_pad'] is too short
From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/clock/imx6q-clock.yaml | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
the fsl-imx-esdhc.yaml file. This is required to match the compatible
strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
commit addresses the following dtbs_check warning:
imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
'nxp,s32g2-usdhc']
From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 2 ++
1 file changed, 2 insertions(+)
Extend the 'clocks' and 'clock-names' properties to support optional
'enet1_ref_pad' and 'enet2_ref_pad' clocks to resolve the following
dtbs_check warning:
imx6ul-prti6g.dtb: clock-controller@20c4000: clocks: [[17], [18], [19],
[20], [21]] is too long
From schema: Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
imx6ul-prti6g.dtb: clock-controller@20c4000: clock-names: ['ckil',
'osc', 'ipp_di0', 'ipp_di1', 'enet1_ref_pad'] is too long
From schema: Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 6 ++++++
1 file changed, 6 insertions(+)
Add a new property 'threshold' to the edt-ft5x06 touchscreen binding.
This property allows setting the "click"-threshold in the range from 0
to 255. This change addresses the following dtbs_check warning:
imx6dl-lanmcu.dtb: touchscreen@38: 'threshold' does not match any of the
regexes: 'pinctrl-[0-9]+'
From schema:
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 6 ++++++
1 file changed, 6 insertions(+)
@@ -93,6 +93,12 @@ properties:minimum:1maximum:255+threshold:+description:Allows setting the "click"-threshold in the range from 0 to 255.+$ref:/schemas/types.yaml#/definitions/uint32+minimum:0+maximum:255+touchscreen-size-x:truetouchscreen-size-y:truetouchscreen-fuzz-x:true
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Add 'fsl,imx6ul-gpt' compatible to resolve the following dtbs_check
warning:
/arch/arm/boot/dts/imx6ull-jozacp.dtb: timer@20e8000: compatible:
'oneOf' conditional failed, one must be fixed:
'fsl,imx6ul-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt',
'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 4 ++++
1 file changed, 4 insertions(+)
Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
binding to resolve the following dtbs_check warning:
imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
1 file changed, 16 insertions(+), 6 deletions(-)
Add support for i.MX6SL, i.MX6SLL, and i.MX6ULL to the 'fsl-dcp' binding
to address the following dtbs_check warning:
imx6ull-jozacp.dtb: crypto@2280000: compatible:0: 'fsl,imx6ull-dcp' is
not one of ['fsl,imx23-dcp', 'fsl,imx28-dcp']
From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
imx6ull-jozacp.dtb: crypto@2280000: compatible: ['fsl,imx6ull-dcp',
'fsl,imx28-dcp'] is too long
From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/crypto/fsl-dcp.yaml | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
On Thu, Jun 01, 2023 at 12:14:45PM +0200, Oleksij Rempel wrote:
quoted hunk
Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
the fsl-imx-esdhc.yaml file. This is required to match the compatible
strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
commit addresses the following dtbs_check warning:
imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
'nxp,s32g2-usdhc']
From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 2 ++
1 file changed, 2 insertions(+)
On Thu, Jun 01, 2023 at 07:18:31PM +0100, Conor Dooley wrote:
On Thu, Jun 01, 2023 at 12:14:45PM +0200, Oleksij Rempel wrote:
quoted
Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
the fsl-imx-esdhc.yaml file. This is required to match the compatible
strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
commit addresses the following dtbs_check warning:
imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
'nxp,s32g2-usdhc']
From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 2 ++
1 file changed, 2 insertions(+)
On Thu, Jun 01, 2023 at 12:14:46PM +0200, Oleksij Rempel wrote:
quoted hunk
Add 'fsl,imx6ul-gpt' compatible to resolve the following dtbs_check
warning:
/arch/arm/boot/dts/imx6ull-jozacp.dtb: timer@20e8000: compatible:
'oneOf' conditional failed, one must be fixed:
'fsl,imx6ul-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt',
'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 4 ++++
1 file changed, 4 insertions(+)
On Thu, Jun 01, 2023 at 12:14:47PM +0200, Oleksij Rempel wrote:
quoted hunk
Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
binding to resolve the following dtbs_check warning:
imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
1 file changed, 16 insertions(+), 6 deletions(-)
On Thu, Jun 01, 2023 at 12:14:48PM +0200, Oleksij Rempel wrote:
quoted hunk
Add support for i.MX6SL, i.MX6SLL, and i.MX6ULL to the 'fsl-dcp' binding
to address the following dtbs_check warning:
imx6ull-jozacp.dtb: crypto@2280000: compatible:0: 'fsl,imx6ull-dcp' is
not one of ['fsl,imx23-dcp', 'fsl,imx28-dcp']
From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
imx6ull-jozacp.dtb: crypto@2280000: compatible: ['fsl,imx6ull-dcp',
'fsl,imx28-dcp'] is too long
From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/crypto/fsl-dcp.yaml | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
I don't get this either. Why set the imx23-dcp as the fallback for the
imx28-dcp, when the imx28-dcp is being used as the fallback for the imx6
stuff?
I get the impression that some of the devicetrees should be fixed up,
rather than adding these sorta odd conditions to the bindings.
To me it'd make sense to swap everything that uses imx28-dcp as a
fallback to use imx23-dcp instead, since that is the most generic one?
What am I missing?
Cheers,
Conor.
From: Krzysztof Kozlowski <hidden> Date: 2023-06-02 08:28:53
On 01/06/2023 12:14, Oleksij Rempel wrote:
Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
the fsl-imx-esdhc.yaml file. This is required to match the compatible
strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
commit addresses the following dtbs_check warning:
imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
'nxp,s32g2-usdhc']
From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Except what Conor wrote, please don't wrap that much the error log - it
is unreadable. Trim it, remove unneeded parts and keep some decent
one/two lines even if it exceeds the commit msg. This applies to other
patches as well.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Rob Herring <robh@kernel.org> Date: 2023-06-14 19:04:10
On Thu, Jun 01, 2023 at 12:14:47PM +0200, Oleksij Rempel wrote:
quoted hunk
Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
binding to resolve the following dtbs_check warning:
imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
1 file changed, 16 insertions(+), 6 deletions(-)
From: Rob Herring <robh@kernel.org> Date: 2023-06-14 19:13:53
On Thu, Jun 01, 2023 at 12:14:49PM +0200, Oleksij Rempel wrote:
quoted hunk
Extend the 'clocks' and 'clock-names' properties to support optional
'enet1_ref_pad' and 'enet2_ref_pad' clocks to resolve the following
dtbs_check warning:
imx6ul-prti6g.dtb: clock-controller@20c4000: clocks: [[17], [18], [19],
[20], [21]] is too long
From schema: Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
imx6ul-prti6g.dtb: clock-controller@20c4000: clock-names: ['ckil',
'osc', 'ipp_di0', 'ipp_di1', 'enet1_ref_pad'] is too long
From schema: Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 6 ++++++
1 file changed, 6 insertions(+)
From: Rob Herring <robh@kernel.org> Date: 2023-06-14 19:18:19
On Thu, Jun 01, 2023 at 12:14:50PM +0200, Oleksij Rempel wrote:
All clocks for this driver are optional, so this change allows the
It's not about what the driver supports, but the h/w. You are saying
this SoC can operate with only 1 of any of the clock inputs?
quoted hunk
'clocks' and 'clock-names' properties to accept a single clock.
Additionally, 'enet_ref_pad' clock is added. This resolves the following
dtbs_check warning:
imx6dl-alti6p.dtb: clock-controller@20c4000: clocks: [[24]] is too short
From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:0: 'osc' was
expected
From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:
['enet_ref_pad'] is too short
From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/clock/imx6q-clock.yaml | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
From: Rob Herring <robh@kernel.org> Date: 2023-06-14 19:21:41
On Thu, 01 Jun 2023 12:14:51 +0200, Oleksij Rempel wrote:
Add a new property 'threshold' to the edt-ft5x06 touchscreen binding.
This property allows setting the "click"-threshold in the range from 0
to 255. This change addresses the following dtbs_check warning:
imx6dl-lanmcu.dtb: touchscreen@38: 'threshold' does not match any of the
regexes: 'pinctrl-[0-9]+'
From schema:
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 6 ++++++
1 file changed, 6 insertions(+)