From: Peng Fan (OSS) <hidden> Date: 2023-03-20 02:02:24
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support,
so use select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
From: Krzysztof Kozlowski <hidden> Date: 2023-03-20 06:56:46
On 20/03/2023 03:07, Peng Fan (OSS) wrote:
quoted hunk
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support,
so use select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
And what about all snps,dwc3 devices there (without specific
compatible)? Previously they were selected and now they are not... so
you just disabled schema for all of them.
I don't understand why you remove your compatible.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Peng Fan <peng.fan@nxp.com> Date: 2023-03-20 11:07:32
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 03:07, Peng Fan (OSS) wrote:
quoted
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support, so use
select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
And what about all snps,dwc3 devices there (without specific compatible)?
Previously they were selected and now they are not... so you just disabled
schema for all of them.
From: Krzysztof Kozlowski <hidden> Date: 2023-03-20 11:39:27
On 20/03/2023 12:02, Peng Fan wrote:
quoted
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 03:07, Peng Fan (OSS) wrote:
quoted
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support, so use
select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
And what about all snps,dwc3 devices there (without specific compatible)?
Previously they were selected and now they are not... so you just disabled
schema for all of them.
I don't understand why you remove your compatible.
[Peng Fan]
My last change drops 'contains' by mistake, and breaks
This I understand.
rockchip,dwc3, so just bring back the original content
This is not a reason to make your compatible undocumented. You basically
revert your patch. It does not make any sense to me.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Peng Fan <peng.fan@nxp.com> Date: 2023-03-20 11:44:41
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 12:02, Peng Fan wrote:
quoted
quoted
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 03:07, Peng Fan (OSS) wrote:
quoted
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support, so use
select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
And what about all snps,dwc3 devices there (without specific compatible)?
Previously they were selected and now they are not... so you just
disabled schema for all of them.
fesB1c%2B3YxohCGM36xySFucVU25WVYIMlpgGkdoWk%3D&reserved=0
Rob suggested use select, but I am not sure how to use it here. Use an
extra yaml file with select or else.
From: Krzysztof Kozlowski <hidden> Date: 2023-03-20 12:05:44
On 20/03/2023 12:44, Peng Fan wrote:
quoted
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 12:02, Peng Fan wrote:
quoted
quoted
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 03:07, Peng Fan (OSS) wrote:
quoted
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support, so use
select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
And what about all snps,dwc3 devices there (without specific compatible)?
Previously they were selected and now they are not... so you just
disabled schema for all of them.
fesB1c%2B3YxohCGM36xySFucVU25WVYIMlpgGkdoWk%3D&reserved=0
Rob suggested use select, but I am not sure how to use it here. Use an
extra yaml file with select or else.
I don't understand why you remove your compatible.
[Peng Fan]
My last change drops 'contains' by mistake, and breaks
This I understand.
quoted
rockchip,dwc3, so just bring back the original content
This is not a reason to make your compatible undocumented. You basically
revert your patch. It does not make any sense to me.
[Peng Fan]
ok, let me think more. Honestly not have good idea (:
If you have any guidance, that would be helpful.
You should only need a select, however most likely selecting also
snps,dwc3 (without specific compatible). Anyway this binding - including
how it is referenced by others - is getting unmanagable. I think I
commented about this on some other occasion. The point is that no one
refactors it thus it grows and grows leading to more of such tricky
scenarios.
How it should be refactored? Probably just like all other with re-usable
components: common part and device specific bindings including it. While
snps,dwc3 alone should not be allowed anymore.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Peng Fan <peng.fan@nxp.com> Date: 2023-03-20 14:06:18
-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: 2023年3月20日 20:06
To: Peng Fan <peng.fan@nxp.com>; Peng Fan (OSS)
[off-list ref]; gregkh@linuxfoundation.org;
robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
shawnguo@kernel.org; s.hauer@pengutronix.de; Xu Yang
[off-list ref]
Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-
imx@nxp.com>; linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li
[off-list ref]
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 12:44, Peng Fan wrote:
quoted
quoted
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct
i.MX8MQ support
On 20/03/2023 12:02, Peng Fan wrote:
quoted
quoted
Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3:
correct i.MX8MQ support
On 20/03/2023 03:07, Peng Fan (OSS) wrote:
quoted
From: Peng Fan <peng.fan@nxp.com>
The previous i.MX8MQ support breaks rockchip,dwc3 support, so use
select to restrict i.MX8MQ support and avoid break others.
Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support
i.MX8MQ")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
.../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++----
I don't understand why you remove your compatible.
[Peng Fan]
My last change drops 'contains' by mistake, and breaks
This I understand.
quoted
rockchip,dwc3, so just bring back the original content
This is not a reason to make your compatible undocumented. You
basically revert your patch. It does not make any sense to me.
[Peng Fan]
ok, let me think more. Honestly not have good idea (:
If you have any guidance, that would be helpful.
You should only need a select, however most likely selecting also
snps,dwc3 (without specific compatible). Anyway this binding - including
how it is referenced by others - is getting unmanagable. I think I commented
about this on some other occasion. The point is that no one refactors it thus
it grows and grows leading to more of such tricky scenarios.
How it should be refactored? Probably just like all other with re-usable
components: common part and device specific bindings including it. While
snps,dwc3 alone should not be allowed anymore.
Thanks, I may take rockchip,dwc3.yaml or other vendor,dwc3.yaml as
reference to introduce fsl-imx8mq,dwc3.yaml to just add a select, and
drop the fsl,imx8mq-dwc3 compatible from snps,dwc3.yaml.
Thanks,
Peng.