[PATCH linux-next v2] drm/mediatek: Remove the unneeded result

STALE1440d

3 messages, 3 authors, 2022-08-25 · open the first message on its own page

[PATCH linux-next v2] drm/mediatek: Remove the unneeded result

From: <hidden>
Date: 2022-08-25 07:24:08

From: ye xingchen <redacted>

Return the value drm_mode_config_helper_suspend() directly instead of
 storing it in another redundant variable.

Reported-by: Zeal Robot <redacted>
Signed-off-by: ye xingchen <redacted>
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
 {
 	struct mtk_drm_private *private = dev_get_drvdata(dev);
 	struct drm_device *drm = private->drm;
-	int ret;
-
-	ret = drm_mode_config_helper_suspend(drm);
 
-	return ret;
+	return drm_mode_config_helper_suspend(drm);
 }
 
 static void mtk_drm_sys_complete(struct device *dev)
-- 
2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2022-08-25 13:09:10


On 25/08/2022 09:23, cgel.zte@gmail.com wrote:
From: ye xingchen <redacted>

Return the value drm_mode_config_helper_suspend() directly instead of
  storing it in another redundant variable.

Reported-by: Zeal Robot <redacted>
Signed-off-by: ye xingchen <redacted>
I thought I already did this in v1, anyway here we go again:

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
quoted hunk
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
  {
  	struct mtk_drm_private *private = dev_get_drvdata(dev);
  	struct drm_device *drm = private->drm;
-	int ret;
-
-	ret = drm_mode_config_helper_suspend(drm);
  
-	return ret;
+	return drm_mode_config_helper_suspend(drm);
  }
  
  static void mtk_drm_sys_complete(struct device *dev)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2022-08-25 23:39:13

Hi, cgel:

[off-list ref] 於 2022年8月25日 週四 下午3:24寫道:
From: ye xingchen <redacted>

Return the value drm_mode_config_helper_suspend() directly instead of
 storing it in another redundant variable.
Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.
quoted hunk
Reported-by: Zeal Robot <redacted>
Signed-off-by: ye xingchen <redacted>
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
 {
        struct mtk_drm_private *private = dev_get_drvdata(dev);
        struct drm_device *drm = private->drm;
-       int ret;
-
-       ret = drm_mode_config_helper_suspend(drm);

-       return ret;
+       return drm_mode_config_helper_suspend(drm);
 }

 static void mtk_drm_sys_complete(struct device *dev)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help