# Re: \[PATCH v2 4/5\] vfio/iommu\_type1: Clean up update\_dirty\_scope in detach\_group()

- From: Nicolin Chen \<hidden\>
- Date: 2022-06-16 22:26:20 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2022/06/1824482
- Thread: https://ratatoskr.run/linux-s390/2022/06/1823167/t.md

```text
On Thu, Jun 16, 2022 at 06:45:09AM +0000, Tian, Kevin wrote:

> > +out_unlock:
> >       mutex_unlock(&iommu->lock);
> >  }
> >
> 
> I'd just replace the goto with a direct unlock and then return there.
> the readability is slightly better.

OK. Will do that.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
