[PATCH v2] dt-bindings: mfd: samsung, exynos5433-lpass: drop useless 'dma-channels/requests' properties

DORMANTno replies REVIEWED: 2 (2M)

From: Krzysztof Kozlowski <hidden>
Date: 2022-05-16 14:11:57
Also in: linux-devicetree, linux-samsung-soc, lkml
Subsystem: multifunction devices (mfd), open firmware and flattened device tree bindings, the rest · Maintainers: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds

2 review trailers (1 from subsystem maintainers).

The pl330 DMA controller provides number of DMA channels and requests
through its registers, so duplicating this information (with a chance of
mistakes) in DTS is pointless.  Additionally the DTS used always wrong
property names which causes DT schema check failures - the bindings
documented 'dma-channels' and 'dma-requests' properties without leading
hash sign.

Reported-by: Rob Herring <robh@kernel.org>
Fixes: e18183cefc8b ("mfd: Add DT bindings documentation for Samsung Exynos LPASS")
Signed-off-by: Krzysztof Kozlowski <redacted>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Rob Herring <robh@kernel.org>

---

Changes since v1:
1. v1 was ment to be applied but I cannot find it in MFD tree.
2. Drop the properties entirely as turned out during discussions.

v1: https://lore.kernel.org/all/YmpkE0FgEhPNneg+@google.com/ (local)
---
 .../devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml       | 2 --
 1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
index f7bb67d10eff..69c15744c864 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
@@ -79,8 +79,6 @@ examples:
             clocks = <&cmu_aud CLK_ACLK_DMAC>;
             clock-names = "apb_pclk";
             #dma-cells = <1>;
-            #dma-channels = <8>;
-            #dma-requests = <32>;
             power-domains = <&pd_aud>;
         };
 
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help