[PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

Subsystems: arm/freescale imx / mxc / layerscape arm architecture, the rest

STALE1660d

7 messages, 4 authors, 2022-04-06 · open the first message on its own page

[PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

From: Michael Walle <hidden>
Date: 2022-02-24 10:30:41 

Use the power signal names as given in the schematics of the reference
board.

Signed-off-by: Michael Walle <redacted>
---
Changes since v1:
 - swap buck1 and buck2

 arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index b4225cfcb6d9..2b685c0c7eeb 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -41,7 +41,7 @@ pmic: pmic@25 {
 
 		regulators {
 			buck1: BUCK1{
-				regulator-name = "BUCK1";
+				regulator-name = "VDD_SOC";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <2187500>;
 				regulator-boot-on;
@@ -50,7 +50,7 @@ buck1: BUCK1{
 			};
 
 			buck2: BUCK2 {
-				regulator-name = "BUCK2";
+				regulator-name = "VDD_ARM_0V9";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <2187500>;
 				regulator-boot-on;
@@ -61,7 +61,7 @@ buck2: BUCK2 {
 			};
 
 			buck4: BUCK4{
-				regulator-name = "BUCK4";
+				regulator-name = "VDD_3V3";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <3400000>;
 				regulator-boot-on;
@@ -69,7 +69,7 @@ buck4: BUCK4{
 			};
 
 			buck5: BUCK5{
-				regulator-name = "BUCK5";
+				regulator-name = "VDD_1V8";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <3400000>;
 				regulator-boot-on;
@@ -77,7 +77,7 @@ buck5: BUCK5{
 			};
 
 			buck6: BUCK6 {
-				regulator-name = "BUCK6";
+				regulator-name = "NVCC_DRAM_1V1";
 				regulator-min-microvolt = <600000>;
 				regulator-max-microvolt = <3400000>;
 				regulator-boot-on;
@@ -85,7 +85,7 @@ buck6: BUCK6 {
 			};
 
 			ldo1: LDO1 {
-				regulator-name = "LDO1";
+				regulator-name = "NVCC_SNVS_1V8";
 				regulator-min-microvolt = <1600000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
@@ -93,7 +93,7 @@ ldo1: LDO1 {
 			};
 
 			ldo2: LDO2 {
-				regulator-name = "LDO2";
+				regulator-name = "VDD_SNVS_0V8";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1150000>;
 				regulator-boot-on;
@@ -101,7 +101,7 @@ ldo2: LDO2 {
 			};
 
 			ldo3: LDO3 {
-				regulator-name = "LDO3";
+				regulator-name = "VDDA_1V8";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
@@ -109,7 +109,7 @@ ldo3: LDO3 {
 			};
 
 			ldo4: LDO4 {
-				regulator-name = "LDO4";
+				regulator-name = "VDD_PHY_1V2";
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
@@ -117,7 +117,7 @@ ldo4: LDO4 {
 			};
 
 			ldo5: LDO5 {
-				regulator-name = "LDO5";
+				regulator-name = "NVCC_SD2";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC

From: Michael Walle <hidden>
Date: 2022-02-24 10:30:44 

Use the proper voltages as supported by the board instead of the ones
supported by the PMIC. The voltages were taken from both the schematic
of the 8MNANOLPD4-EVK eval board and the datasheet of the IMX8MN SoC.

Signed-off-by: Michael Walle <redacted>
---
Please help review and test this. This was never tested on the actual
8MNANOLPD4-EVK because I don't have that board! Instead it is a
"byproduct" of the development of an devicetree for the 8MNANOD3L-EVK
which is quite similar except for the DDR voltage and the buck2
converter.

Changes since v1:
 - swap buck1 and buck2

 arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 34 ++++++++++----------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index 2b685c0c7eeb..4eb467df5ba7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -42,8 +42,8 @@ pmic: pmic@25 {
 		regulators {
 			buck1: BUCK1{
 				regulator-name = "VDD_SOC";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <2187500>;
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <950000>;
 				regulator-boot-on;
 				regulator-always-on;
 				regulator-ramp-delay = <3125>;
@@ -51,8 +51,8 @@ buck1: BUCK1{
 
 			buck2: BUCK2 {
 				regulator-name = "VDD_ARM_0V9";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <2187500>;
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1000000>;
 				regulator-boot-on;
 				regulator-always-on;
 				regulator-ramp-delay = <3125>;
@@ -62,32 +62,32 @@ buck2: BUCK2 {
 
 			buck4: BUCK4{
 				regulator-name = "VDD_3V3";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <3400000>;
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
 
 			buck5: BUCK5{
 				regulator-name = "VDD_1V8";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <3400000>;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
 
 			buck6: BUCK6 {
 				regulator-name = "NVCC_DRAM_1V1";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <3400000>;
+				regulator-min-microvolt = <1100000>;
+				regulator-max-microvolt = <1100000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
 
 			ldo1: LDO1 {
 				regulator-name = "NVCC_SNVS_1V8";
-				regulator-min-microvolt = <1600000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
@@ -95,23 +95,23 @@ ldo1: LDO1 {
 			ldo2: LDO2 {
 				regulator-name = "VDD_SNVS_0V8";
 				regulator-min-microvolt = <800000>;
-				regulator-max-microvolt = <1150000>;
+				regulator-max-microvolt = <800000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
 
 			ldo3: LDO3 {
 				regulator-name = "VDDA_1V8";
-				regulator-min-microvolt = <800000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
 
 			ldo4: LDO4 {
 				regulator-name = "VDD_PHY_1V2";
-				regulator-min-microvolt = <800000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <1200000>;
+				regulator-max-microvolt = <1200000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC

From: Heiko Thiery <hidden>
Date: 2022-02-24 12:09:47 

Hi,

Am Do., 24. Feb. 2022 um 11:30 Uhr schrieb Michael Walle [off-list ref]:
Use the proper voltages as supported by the board instead of the ones
supported by the PMIC. The voltages were taken from both the schematic
of the 8MNANOLPD4-EVK eval board and the datasheet of the IMX8MN SoC.

Signed-off-by: Michael Walle <redacted>
Reviewed-by: Heiko Thiery <redacted>
quoted hunk
---
Please help review and test this. This was never tested on the actual
8MNANOLPD4-EVK because I don't have that board! Instead it is a
"byproduct" of the development of an devicetree for the 8MNANOD3L-EVK
which is quite similar except for the DDR voltage and the buck2
converter.

Changes since v1:
 - swap buck1 and buck2

 arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 34 ++++++++++----------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index 2b685c0c7eeb..4eb467df5ba7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -42,8 +42,8 @@ pmic: pmic@25 {
                regulators {
                        buck1: BUCK1{
                                regulator-name = "VDD_SOC";
-                               regulator-min-microvolt = <600000>;
-                               regulator-max-microvolt = <2187500>;
+                               regulator-min-microvolt = <850000>;
+                               regulator-max-microvolt = <950000>;
                                regulator-boot-on;
                                regulator-always-on;
                                regulator-ramp-delay = <3125>;
@@ -51,8 +51,8 @@ buck1: BUCK1{

                        buck2: BUCK2 {
                                regulator-name = "VDD_ARM_0V9";
-                               regulator-min-microvolt = <600000>;
-                               regulator-max-microvolt = <2187500>;
+                               regulator-min-microvolt = <850000>;
+                               regulator-max-microvolt = <1000000>;
                                regulator-boot-on;
                                regulator-always-on;
                                regulator-ramp-delay = <3125>;
@@ -62,32 +62,32 @@ buck2: BUCK2 {

                        buck4: BUCK4{
                                regulator-name = "VDD_3V3";
-                               regulator-min-microvolt = <600000>;
-                               regulator-max-microvolt = <3400000>;
+                               regulator-min-microvolt = <3300000>;
+                               regulator-max-microvolt = <3300000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };

                        buck5: BUCK5{
                                regulator-name = "VDD_1V8";
-                               regulator-min-microvolt = <600000>;
-                               regulator-max-microvolt = <3400000>;
+                               regulator-min-microvolt = <1800000>;
+                               regulator-max-microvolt = <1800000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };

                        buck6: BUCK6 {
                                regulator-name = "NVCC_DRAM_1V1";
-                               regulator-min-microvolt = <600000>;
-                               regulator-max-microvolt = <3400000>;
+                               regulator-min-microvolt = <1100000>;
+                               regulator-max-microvolt = <1100000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };

                        ldo1: LDO1 {
                                regulator-name = "NVCC_SNVS_1V8";
-                               regulator-min-microvolt = <1600000>;
-                               regulator-max-microvolt = <3300000>;
+                               regulator-min-microvolt = <1800000>;
+                               regulator-max-microvolt = <1800000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };
@@ -95,23 +95,23 @@ ldo1: LDO1 {
                        ldo2: LDO2 {
                                regulator-name = "VDD_SNVS_0V8";
                                regulator-min-microvolt = <800000>;
-                               regulator-max-microvolt = <1150000>;
+                               regulator-max-microvolt = <800000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };

                        ldo3: LDO3 {
                                regulator-name = "VDDA_1V8";
-                               regulator-min-microvolt = <800000>;
-                               regulator-max-microvolt = <3300000>;
+                               regulator-min-microvolt = <1800000>;
+                               regulator-max-microvolt = <1800000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };

                        ldo4: LDO4 {
                                regulator-name = "VDD_PHY_1V2";
-                               regulator-min-microvolt = <800000>;
-                               regulator-max-microvolt = <3300000>;
+                               regulator-min-microvolt = <1200000>;
+                               regulator-max-microvolt = <1200000>;
                                regulator-boot-on;
                                regulator-always-on;
                        };
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

From: Heiko Thiery <hidden>
Date: 2022-02-24 12:11:09 

HI,

Am Do., 24. Feb. 2022 um 11:30 Uhr schrieb Michael Walle [off-list ref]:
Use the power signal names as given in the schematics of the reference
board.

Signed-off-by: Michael Walle <redacted>
Reviewed-by: Heiko Thiery <redacted>
quoted hunk
---
Changes since v1:
 - swap buck1 and buck2

 arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index b4225cfcb6d9..2b685c0c7eeb 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -41,7 +41,7 @@ pmic: pmic@25 {

                regulators {
                        buck1: BUCK1{
-                               regulator-name = "BUCK1";
+                               regulator-name = "VDD_SOC";
                                regulator-min-microvolt = <600000>;
                                regulator-max-microvolt = <2187500>;
                                regulator-boot-on;
@@ -50,7 +50,7 @@ buck1: BUCK1{
                        };

                        buck2: BUCK2 {
-                               regulator-name = "BUCK2";
+                               regulator-name = "VDD_ARM_0V9";
                                regulator-min-microvolt = <600000>;
                                regulator-max-microvolt = <2187500>;
                                regulator-boot-on;
@@ -61,7 +61,7 @@ buck2: BUCK2 {
                        };

                        buck4: BUCK4{
-                               regulator-name = "BUCK4";
+                               regulator-name = "VDD_3V3";
                                regulator-min-microvolt = <600000>;
                                regulator-max-microvolt = <3400000>;
                                regulator-boot-on;
@@ -69,7 +69,7 @@ buck4: BUCK4{
                        };

                        buck5: BUCK5{
-                               regulator-name = "BUCK5";
+                               regulator-name = "VDD_1V8";
                                regulator-min-microvolt = <600000>;
                                regulator-max-microvolt = <3400000>;
                                regulator-boot-on;
@@ -77,7 +77,7 @@ buck5: BUCK5{
                        };

                        buck6: BUCK6 {
-                               regulator-name = "BUCK6";
+                               regulator-name = "NVCC_DRAM_1V1";
                                regulator-min-microvolt = <600000>;
                                regulator-max-microvolt = <3400000>;
                                regulator-boot-on;
@@ -85,7 +85,7 @@ buck6: BUCK6 {
                        };

                        ldo1: LDO1 {
-                               regulator-name = "LDO1";
+                               regulator-name = "NVCC_SNVS_1V8";
                                regulator-min-microvolt = <1600000>;
                                regulator-max-microvolt = <3300000>;
                                regulator-boot-on;
@@ -93,7 +93,7 @@ ldo1: LDO1 {
                        };

                        ldo2: LDO2 {
-                               regulator-name = "LDO2";
+                               regulator-name = "VDD_SNVS_0V8";
                                regulator-min-microvolt = <800000>;
                                regulator-max-microvolt = <1150000>;
                                regulator-boot-on;
@@ -101,7 +101,7 @@ ldo2: LDO2 {
                        };

                        ldo3: LDO3 {
-                               regulator-name = "LDO3";
+                               regulator-name = "VDDA_1V8";
                                regulator-min-microvolt = <800000>;
                                regulator-max-microvolt = <3300000>;
                                regulator-boot-on;
@@ -109,7 +109,7 @@ ldo3: LDO3 {
                        };

                        ldo4: LDO4 {
-                               regulator-name = "LDO4";
+                               regulator-name = "VDD_PHY_1V2";
                                regulator-min-microvolt = <800000>;
                                regulator-max-microvolt = <3300000>;
                                regulator-boot-on;
@@ -117,7 +117,7 @@ ldo4: LDO4 {
                        };

                        ldo5: LDO5 {
-                               regulator-name = "LDO5";
+                               regulator-name = "NVCC_SD2";
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <3300000>;
                                regulator-boot-on;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

From: Fabio Estevam <festevam@gmail.com>
Date: 2022-02-26 12:59:02 

Hi Michael,

On Thu, Feb 24, 2022 at 7:30 AM Michael Walle [off-list ref] wrote:
Use the power signal names as given in the schematics of the reference
board.

Signed-off-by: Michael Walle <redacted>
---
Changes since v1:
 - swap buck1 and buck2
Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

From: Michael Walle <hidden>
Date: 2022-03-14 07:30:33 

Hi,

Am 2022-02-24 11:30, schrieb Michael Walle:
Use the power signal names as given in the schematics of the reference
board.

Signed-off-by: Michael Walle <redacted>
Any news here?

-michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

From: Shawn Guo <shawnguo@kernel.org>
Date: 2022-04-06 15:55:07 

On Thu, Feb 24, 2022 at 11:30:29AM +0100, Michael Walle wrote:
Use the power signal names as given in the schematics of the reference
board.

Signed-off-by: Michael Walle <redacted>
Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help