[PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC

Subsystems: the rest

STALE1648d

6 messages, 4 authors, 2022-01-28 · open the first message on its own page

[PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC

From: Thierry Reding <hidden>
Date: 2021-12-20 13:44:38 

From: Thierry Reding <redacted>

The "mxim" vendor prefix does not exit, though it looks like it might
have been a typo'ed "maxim". Still, no compatible string exists that
matches "maxim,ds1339". The closest is the "dallas,ds1339" and since
this node is named "rtc" that's probably the one that was intended.

Signed-off-by: Thierry Reding <redacted>
---
 arch/arm/boot/dts/imx28-tx28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 164254c28f8e..a1fd508ee425 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -356,7 +356,7 @@ touchscreen: tsc2007@48 {
 	};
 
 	ds1339: rtc@68 {
-		compatible = "mxim,ds1339";
+		compatible = "dallas,ds1339";
 		reg = <0x68>;
 		trickle-resistor-ohms = <250>;
 		trickle-diode-disable;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] ARM: dts: imx: Rename RTC device tree nodes

From: Thierry Reding <hidden>
Date: 2021-12-20 13:44:43 

From: Thierry Reding <redacted>

Device tree nodes for RTC devices should be called "rtc", so fix up some
instances where that wasn't the case.

Signed-off-by: Thierry Reding <redacted>
---
 arch/arm/boot/dts/imx51-ts4800.dts           | 2 +-
 arch/arm/boot/dts/imx53-tx53.dtsi            | 2 +-
 arch/arm/boot/dts/imx6q-tbs2910.dts          | 2 +-
 arch/arm/boot/dts/imx6qdl-tx6-mb7.dtsi       | 2 +-
 arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts | 2 +-
 arch/arm/boot/dts/imx7-colibri-aster.dtsi    | 2 +-
 arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi  | 2 +-
 arch/arm/boot/dts/vf-colibri-eval-v3.dtsi    | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
index 6ecb83e7f336..85654d6baf28 100644
--- a/arch/arm/boot/dts/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/imx51-ts4800.dts
@@ -102,7 +102,7 @@ &i2c2 {
 	pinctrl-0 = <&pinctrl_i2c2>;
 	status = "okay";
 
-	rtc: m41t00@68 {
+	rtc: rtc@68 {
 		compatible = "st,m41t00";
 		reg = <0x68>;
 	};
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index 7c9730f3f820..572260518098 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -252,7 +252,7 @@ &i2c1 {
 	clock-frequency = <400000>;
 	status = "okay";
 
-	rtc1: ds1339@68 {
+	rtc1: rtc@68 {
 		compatible = "dallas,ds1339";
 		reg = <0x68>;
 		pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts
index 343364d3e4f7..8daef65d5bb3 100644
--- a/arch/arm/boot/dts/imx6q-tbs2910.dts
+++ b/arch/arm/boot/dts/imx6q-tbs2910.dts
@@ -159,7 +159,7 @@ &i2c3 {
 	pinctrl-0 = <&pinctrl_i2c3>;
 	status = "okay";
 
-	rtc: ds1307@68 {
+	rtc: rtc@68 {
 		compatible = "dallas,ds1307";
 		reg = <0x68>;
 	};
diff --git a/arch/arm/boot/dts/imx6qdl-tx6-mb7.dtsi b/arch/arm/boot/dts/imx6qdl-tx6-mb7.dtsi
index 410972e1dca9..99ec7a838f8d 100644
--- a/arch/arm/boot/dts/imx6qdl-tx6-mb7.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-tx6-mb7.dtsi
@@ -85,7 +85,7 @@ &ds1339 {
 };
 
 &i2c3 {
-	rtc: mcp7940x@6f {
+	rtc: rtc@6f {
 		compatible = "microchip,mcp7940x";
 		reg = <0x6f>;
 	};
diff --git a/arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts b/arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts
index 97686097a86e..92ac0edcb608 100644
--- a/arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts
+++ b/arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts
@@ -119,7 +119,7 @@ &i2c2 {
 	/delete-node/ codec@a;
 	/delete-node/ touchscreen@48;
 
-	rtc: mcp7940x@6f {
+	rtc: rtc@6f {
 		compatible = "microchip,mcp7940x";
 		reg = <0x6f>;
 	};
diff --git a/arch/arm/boot/dts/imx7-colibri-aster.dtsi b/arch/arm/boot/dts/imx7-colibri-aster.dtsi
index 139188eb9f40..b770fc937970 100644
--- a/arch/arm/boot/dts/imx7-colibri-aster.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri-aster.dtsi
@@ -103,7 +103,7 @@ touchscreen@4a {
 	};
 
 	/* M41T0M6 real time clock on carrier board */
-	rtc: m41t0m6@68 {
+	rtc: rtc@68 {
 		compatible = "st,m41t0";
 		reg = <0x68>;
 	};
diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
index 3caf450735d7..3b9df8c82ae3 100644
--- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
@@ -129,7 +129,7 @@ touchscreen@4a {
 	};
 
 	/* M41T0M6 real time clock on carrier board */
-	rtc: m41t0m6@68 {
+	rtc: rtc@68 {
 		compatible = "st,m41t0";
 		reg = <0x68>;
 	};
diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
index c12a1b8bc086..14c411f146f5 100644
--- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
@@ -103,7 +103,7 @@ &i2c0 {
 	status = "okay";
 
 	/* M41T0M6 real time clock on carrier board */
-	rtc: m41t0m6@68 {
+	rtc: rtc@68 {
 		compatible = "st,m41t0";
 		reg = <0x68>;
 	};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] ARM: dts: imx: Rename RTC device tree nodes

From: Fabio Estevam <festevam@gmail.com>
Date: 2021-12-20 13:47:53 

On Mon, Dec 20, 2021 at 10:43 AM Thierry Reding
[off-list ref] wrote:
From: Thierry Reding <redacted>

Device tree nodes for RTC devices should be called "rtc", so fix up some
instances where that wasn't the case.

Signed-off-by: Thierry Reding <redacted>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC

From: Fabio Estevam <festevam@gmail.com>
Date: 2021-12-20 13:47:13 

[Adding Lothar on Cc]

On Mon, Dec 20, 2021 at 10:43 AM Thierry Reding
[off-list ref] wrote:
quoted hunk
From: Thierry Reding <redacted>

The "mxim" vendor prefix does not exit, though it looks like it might
have been a typo'ed "maxim". Still, no compatible string exists that
matches "maxim,ds1339". The closest is the "dallas,ds1339" and since
this node is named "rtc" that's probably the one that was intended.

Signed-off-by: Thierry Reding <redacted>
---
 arch/arm/boot/dts/imx28-tx28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 164254c28f8e..a1fd508ee425 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -356,7 +356,7 @@ touchscreen: tsc2007@48 {
        };

        ds1339: rtc@68 {
-               compatible = "mxim,ds1339";
+               compatible = "dallas,ds1339";
Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC

From: Lothar Waßmann <hidden>
Date: 2021-12-21 06:58:25 

Fabio Estevam [off-list ref] wrote:

[Adding Lothar on Cc]

On Mon, Dec 20, 2021 at 10:43 AM Thierry Reding
[off-list ref] wrote:
quoted
From: Thierry Reding <redacted>

The "mxim" vendor prefix does not exit, though it looks like it might
have been a typo'ed "maxim". Still, no compatible string exists that
matches "maxim,ds1339". The closest is the "dallas,ds1339" and since
this node is named "rtc" that's probably the one that was intended.

Signed-off-by: Thierry Reding <redacted>
---
 arch/arm/boot/dts/imx28-tx28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 164254c28f8e..a1fd508ee425 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -356,7 +356,7 @@ touchscreen: tsc2007@48 {
        };

        ds1339: rtc@68 {
-               compatible = "mxim,ds1339";
+               compatible = "dallas,ds1339";  
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Lothar Waßmann <redacted>


-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] ARM: dts: imx28: Use correct compatible string for RTC

From: Shawn Guo <shawnguo@kernel.org>
Date: 2022-01-28 04:05:19 

On Mon, Dec 20, 2021 at 02:43:10PM +0100, Thierry Reding wrote:
From: Thierry Reding <redacted>

The "mxim" vendor prefix does not exit, though it looks like it might
have been a typo'ed "maxim". Still, no compatible string exists that
matches "maxim,ds1339". The closest is the "dallas,ds1339" and since
this node is named "rtc" that's probably the one that was intended.

Signed-off-by: Thierry Reding <redacted>
Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help