[PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

Subsystems: the rest

STALE1648d

6 messages, 3 authors, 2022-01-26 · open the first message on its own page

[PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Marek Vasut <marex@denx.de>
Date: 2021-12-18 15:27:05

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>
---
 arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81dd..a1eb36229ef8 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts

@@ -53,6 +53,29 @@ eth {
 		};
 	};
 
+	lvds-decoder {
+		compatible = "ti,ds90cf364a", "lvds-decoder";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				lvds_decoder_in: endpoint {
+					remote-endpoint = <&lvds0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				lvds_decoder_out: endpoint {
+					remote-endpoint = <&panel_in>;
+				};
+			};
+		};
+	};
+
 	panel {
 		compatible = "edt,etm0700g0dh6";
 		pinctrl-0 = <&pinctrl_display_gpio>;

@@ -61,7 +84,7 @@ panel {
 
 		port {
 			panel_in: endpoint {
-				remote-endpoint = <&lvds0_out>;
+				remote-endpoint = <&lvds_decoder_out>;
 			};
 		};
 	};

@@ -450,7 +473,7 @@ port@2 {
 			reg = <2>;
 
 			lvds0_out: endpoint {
-				remote-endpoint = <&panel_in>;
+				remote-endpoint = <&lvds_decoder_in>;
 			};
 		};
 	};

-- 
2.33.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Fabio Estevam <festevam@gmail.com>
Date: 2021-12-18 15:38:16

On Sat, Dec 18, 2021 at 12:25 PM Marek Vasut [off-list ref] wrote:

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Shawn Guo <shawnguo@kernel.org>
Date: 2022-01-26 12:20:31

On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:

quoted hunk

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>
---
 arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81dd..a1eb36229ef8 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts

@@ -53,6 +53,29 @@ eth {
 		};
 	};
 
+	lvds-decoder {
+		compatible = "ti,ds90cf364a", "lvds-decoder";

Is this "ti,ds90cf364a" documented anywhere?

+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;

Please have a newline between property and child node.

Shawn

quoted hunk

+				lvds_decoder_in: endpoint {
+					remote-endpoint = <&lvds0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				lvds_decoder_out: endpoint {
+					remote-endpoint = <&panel_in>;
+				};
+			};
+		};
+	};
+
 	panel {
 		compatible = "edt,etm0700g0dh6";
 		pinctrl-0 = <&pinctrl_display_gpio>;

@@ -61,7 +84,7 @@ panel {
 
 		port {
 			panel_in: endpoint {
-				remote-endpoint = <&lvds0_out>;
+				remote-endpoint = <&lvds_decoder_out>;
 			};
 		};
 	};

@@ -450,7 +473,7 @@ port@2 {
 			reg = <2>;
 
 			lvds0_out: endpoint {
-				remote-endpoint = <&panel_in>;
+				remote-endpoint = <&lvds_decoder_in>;
 			};
 		};
 	};

-- 
2.33.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Marek Vasut <marex@denx.de>
Date: 2022-01-26 12:40:21

On 1/26/22 13:19, Shawn Guo wrote:

On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:

quoted

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>
---
  arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
  1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81dd..a1eb36229ef8 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts

@@ -53,6 +53,29 @@ eth {
  		};
  	};
  
+	lvds-decoder {
+		compatible = "ti,ds90cf364a", "lvds-decoder";

Is this "ti,ds90cf364a" documented anywhere?

Here is a RB'd patch, currently waiting for someone from dri-devel to 
pick it:

https://patchwork.freedesktop.org/series/98203/

quoted

+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;

Please have a newline between property and child node.

Maybe you can fix this up when applying ?

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Shawn Guo <shawnguo@kernel.org>
Date: 2022-01-26 13:04:14

On Wed, Jan 26, 2022 at 01:39:00PM +0100, Marek Vasut wrote:

On 1/26/22 13:19, Shawn Guo wrote:

quoted

On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:

quoted

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>
---
  arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
  1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81dd..a1eb36229ef8 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts

@@ -53,6 +53,29 @@ eth {
  		};
  	};
+	lvds-decoder {
+		compatible = "ti,ds90cf364a", "lvds-decoder";

Is this "ti,ds90cf364a" documented anywhere?

Here is a RB'd patch, currently waiting for someone from dri-devel to pick
it:

https://patchwork.freedesktop.org/series/98203/

I will have to wait till it lands.

Shawn

quoted

+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;

Please have a newline between property and child node.

Maybe you can fix this up when applying ?

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Marek Vasut <marex@denx.de>
Date: 2022-01-26 13:37:08

On 1/26/22 14:02, Shawn Guo wrote:

On Wed, Jan 26, 2022 at 01:39:00PM +0100, Marek Vasut wrote:

quoted

On 1/26/22 13:19, Shawn Guo wrote:

quoted

On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:

quoted

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <redacted>
---
   arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
   1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81dd..a1eb36229ef8 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts

@@ -53,6 +53,29 @@ eth {
   		};
   	};
+	lvds-decoder {
+		compatible = "ti,ds90cf364a", "lvds-decoder";

Is this "ti,ds90cf364a" documented anywhere?

Here is a RB'd patch, currently waiting for someone from dri-devel to pick
it:

https://patchwork.freedesktop.org/series/98203/

I will have to wait till it lands.

Of course.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help