From: Maxime Ripard <hidden> Date: 2021-12-13 09:25:10
Hi,
The VC4 driver has had limited support to disable the HDMI controllers and
pixelvalves at boot if the firmware has enabled them.
However, this proved to be limited, and a bit unreliable so a new firmware
command has been introduced some time ago to make it free all its resources and
disable any display output it might have enabled.
This series takes advantage of that command to call it once the transition from
simplefb to the KMS driver has been done.
Let me know what you think,
Maxime
---
Changes from v2:
- Switch back to rpi_firmware_get / rpi_firmware_put
- Moved the rpi_firmware pointer to a local variable
Changes from v1:
- Use of_find_compatible_node instead of a phandle
- Use devm_rpi_firmware_get
Maxime Ripard (3):
firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE
drm/vc4: Remove conflicting framebuffers before callind bind_all
drm/vc4: Notify the firmware when DRM is in charge
drivers/gpu/drm/vc4/vc4_drv.c | 30 +++++++++++++++++++---
include/soc/bcm2835/raspberrypi-firmware.h | 1 +
2 files changed, 27 insertions(+), 4 deletions(-)
--
2.33.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Maxime Ripard <hidden> Date: 2021-12-13 09:25:14
The RPI_FIRMWARE_NOTIFY_DISPLAY_DONE firmware call allows to tell the
firmware the kernel is in charge of the display now and the firmware can
free whatever resources it was using.
Acked-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: Maxime Ripard <redacted>
---
include/soc/bcm2835/raspberrypi-firmware.h | 1 +
1 file changed, 1 insertion(+)
From: Maxime Ripard <hidden> Date: 2021-12-13 09:25:20
The bind hooks will modify their controller registers, so simplefb is
going to be unusable anyway. Let's avoid any transient state where it
could still be in the system but no longer functionnal.
Acked-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: Maxime Ripard <redacted>
---
drivers/gpu/drm/vc4/vc4_drv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
From: Maxime Ripard <hidden> Date: 2021-12-13 09:25:26
Once the call to drm_fb_helper_remove_conflicting_framebuffers() has
been made, simplefb has been unregistered and the KMS driver is entirely
in charge of the display.
Thus, we can notify the firmware it can free whatever resource it was
using to maintain simplefb functional.
Signed-off-by: Maxime Ripard <redacted>
---
drivers/gpu/drm/vc4/vc4_drv.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
From: Thomas Zimmermann <tzimmermann@suse.de> Date: 2021-12-13 09:49:38
Hi Maxime
Am 13.12.21 um 10:25 schrieb Maxime Ripard:
quoted hunk
The bind hooks will modify their controller registers, so simplefb is
going to be unusable anyway. Let's avoid any transient state where it
could still be in the system but no longer functionnal.
Acked-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: Maxime Ripard <redacted>
---
drivers/gpu/drm/vc4/vc4_drv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
@@ -251,6 +251,10 @@ static int vc4_drm_bind(struct device *dev)
Since you work on this, I'd like to suggest to call
drm_firmware_drivers_only() at the very top of this function. It's our
new interface for the kernel's nomodeset argument. If it returns false,
the user has disabled native drivers for this boot. The generic DRM
driver will continue to run the device.
if (ret)
return ret;
+ ret = drm_aperture_remove_framebuffers(false, &vc4_drm_driver);
+ if (ret)
+ return ret;
+
There's quite a bit of work being done before calling this function.
None of it is allowed to touch HW.
Is that reliable? If so, the code is fine, otherwise the call should go
to the top of the function.
Best regards
Thomas
quoted hunk
ret = component_bind_all(dev, drm);
if (ret)
return ret;
@@ -259,10 +263,6 @@ static int vc4_drm_bind(struct device *dev) if (ret) goto unbind_all;- ret = drm_aperture_remove_framebuffers(false, &vc4_drm_driver);- if (ret)- goto unbind_all;- ret = vc4_kms_load(drm); if (ret < 0) goto unbind_all;
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
From: Thomas Zimmermann <tzimmermann@suse.de> Date: 2021-12-13 09:54:10
Am 13.12.21 um 10:47 schrieb Thomas Zimmermann:
Hi Maxime
Am 13.12.21 um 10:25 schrieb Maxime Ripard:
quoted
The bind hooks will modify their controller registers, so simplefb is
going to be unusable anyway. Let's avoid any transient state where it
could still be in the system but no longer functionnal.
Acked-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: Maxime Ripard <redacted>
---
drivers/gpu/drm/vc4/vc4_drv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c
b/drivers/gpu/drm/vc4/vc4_drv.c
index 16abc3a3d601..8ab89f805826 100644
@@ -251,6 +251,10 @@ static int vc4_drm_bind(struct device *dev)
Since you work on this, I'd like to suggest to call
drm_firmware_drivers_only() at the very top of this function. It's our
new interface for the kernel's nomodeset argument. If it returns false,
s/false/true
the user has disabled native drivers for this boot. The generic DRM
driver will continue to run the device.
quoted
if (ret)
return ret;
+ ret = drm_aperture_remove_framebuffers(false, &vc4_drm_driver);
+ if (ret)
+ return ret;
+
There's quite a bit of work being done before calling this function.
None of it is allowed to touch HW.
Is that reliable? If so, the code is fine, otherwise the call should go
to the top of the function.
Best regards
Thomas
quoted
ret = component_bind_all(dev, drm);
if (ret)
return ret;
@@ -259,10 +263,6 @@ static int vc4_drm_bind(struct device *dev)
if (ret)
goto unbind_all;
- ret = drm_aperture_remove_framebuffers(false, &vc4_drm_driver);
- if (ret)
- goto unbind_all;
-
ret = vc4_kms_load(drm);
if (ret < 0)
goto unbind_all;
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev