# \[PATCH\] firmware: ti\_sci: inproper error handling of ti\_sci\_probe

- From: Peiwei Hu \<hidden\>
- Date: 2021-12-28 10:01:25 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/12/1619812
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/12/1619812/t.md

```text
goto out instead of returning directly in error exiting

Signed-off-by: Peiwei Hu <redacted>
---
 drivers/firmware/ti_sci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 235c7e7869aa..4500456a9a27 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -3412,7 +3412,7 @@ static int ti_sci_probe(struct platform_device *pdev)
 		ret = register_restart_handler(&info->nb);
 		if (ret) {
 			dev_err(dev, "reboot registration fail(%d)\n", ret);
-			return ret;
+			goto out;
 		}
 	}
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
