[PATCH] ARM: dts: at91: sama5d2: Name the qspi clock

Subsystems: the rest

STALE1692d LANDED

Landed in mainline as cf4060f1bb64 on 2021-12-13.

2 messages, 2 authors, 2021-12-13 · open the first message on its own page

[PATCH] ARM: dts: at91: sama5d2: Name the qspi clock

From: Tudor Ambarus <hidden>
Date: 2021-12-09 10:25:49

Naming clocks is a good practice. The atmel-quadspi driver supports
an unnamed clock for the peripheral clock in order to be backward
compatible with old DTs, but it is recommended to name the clocks
on new DTs. The driver's bindings file requires the clock-names
property, so name the clock.

Signed-off-by: Tudor Ambarus <redacted>
---
 arch/arm/boot/dts/sama5d2.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 801969c113d6..09c741e8ecb8 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi

@@ -288,6 +288,7 @@ qspi0: spi@f0020000 {
 				reg-names = "qspi_base", "qspi_mmap";
 				interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
+				clock-names = "pclk";
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";

@@ -299,6 +300,7 @@ qspi1: spi@f0024000 {
 				reg-names = "qspi_base", "qspi_mmap";
 				interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 53>;
+				clock-names = "pclk";
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock

From: Nicolas Ferre <nicolas.ferre@microchip.com>
Date: 2021-12-13 13:47:30

On 09/12/2021 at 11:25, Tudor Ambarus wrote:

Naming clocks is a good practice. The atmel-quadspi driver supports
an unnamed clock for the peripheral clock in order to be backward
compatible with old DTs, but it is recommended to name the clocks
on new DTs. The driver's bindings file requires the clock-names
property, so name the clock.

Signed-off-by: Tudor Ambarus <redacted>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Queued in at91-dt branch for 5.17.
Best regards,
   Nicolas

quoted hunk

---
  arch/arm/boot/dts/sama5d2.dtsi | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 801969c113d6..09c741e8ecb8 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi

@@ -288,6 +288,7 @@ qspi0: spi@f0020000 {
  				reg-names = "qspi_base", "qspi_mmap";
  				interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
  				clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
+				clock-names = "pclk";
  				#address-cells = <1>;
  				#size-cells = <0>;
  				status = "disabled";

@@ -299,6 +300,7 @@ qspi1: spi@f0024000 {
  				reg-names = "qspi_base", "qspi_mmap";
  				interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>;
  				clocks = <&pmc PMC_TYPE_PERIPHERAL 53>;
+				clock-names = "pclk";
  				#address-cells = <1>;
  				#size-cells = <0>;
  				status = "disabled";


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help