[PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()

Subsystems: freescale soc sound drivers, sound, sound - soc layer / dynamic audio power management (asoc), the rest

STALE1708d

2 messages, 2 authors, 2021-12-08 · open the first message on its own page

[PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()

From: Qing Wang <hidden>
Date: 2021-12-07 12:57:17

From: Wang Qing <redacted>

of_find_device_by_node() takes a reference to the embedded struct device 
which needs to be dropped when error return.

Signed-off-by: Wang Qing <redacted>
---
 sound/soc/fsl/imx-hdmi.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
index 929f69b..89fd8ad
--- a/sound/soc/fsl/imx-hdmi.c
+++ b/sound/soc/fsl/imx-hdmi.c
@@ -125,6 +125,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
 
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
 	if (!data) {
+		put_device(&cpu_pdev->dev);
 		ret = -ENOMEM;
 		goto fail;
 	}
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()

From: Mark Brown <broonie@kernel.org>
Date: 2021-12-08 14:05:15

On Tue, Dec 07, 2021 at 04:56:58AM -0800, Qing Wang wrote:
From: Wang Qing <redacted>

of_find_device_by_node() takes a reference to the embedded struct device 
which needs to be dropped when error return.
...
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
 	if (!data) {
+		put_device(&cpu_pdev->dev);
If it's of_find_device_by_node() you need an of_node_put() since you're
dropping a reference on the OF node.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help