# Re: \[RFC PATCH 4/7\] static\_call: fix broken static\_call\_query() for non-exported keys

- From: Peter Zijlstra \<peterz@infradead.org\>
- Date: 2021-11-09 18:56:23 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/11/1567233
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/11/1567125/t.md

```text
On Tue, Nov 09, 2021 at 05:45:46PM +0100, Ard Biesheuvel wrote:
> static_call_query() accesses the func member of the static call key
> directly, which means that it is broken for cases where it is used from
> a module and the key resides elsewhere and is not exported.
> 

Arguably when the module can't change the value, it shouldn't be having
any interest in obtaining said value either.

I really think you're exporting too much. Modules aren't good, they
deserve to suffer.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```