[PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0

Subsystems: mediatek usb3 drd ip driver, the rest, usb subsystem, usb xhci driver

STALE1724d

Revision v2 of 2 in this series.

5 messages, 2 authors, 2021-11-13 · open the first message on its own page

[PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0

From: Sergey Shtylyov <hidden>
Date: 2021-10-26 17:42:38

If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...

Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")
Signed-off-by: Sergey Shtylyov <redacted>
---
 drivers/usb/host/xhci-mtk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index c53f6f276d5c..d2dc8d9863ee 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c

@@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device *pdev)
 		return ret;
 
 	irq = platform_get_irq_byname_optional(pdev, "host");
-	if (irq < 0) {
+	if (irq <= 0) {
 		if (irq == -EPROBE_DEFER)
 			return irq;

@@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device *pdev)
 		irq = platform_get_irq(pdev, 0);
 		if (irq < 0)
 			return irq;
+		if (!irq)
+			return -EINVAL;
 	}
 
 	wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");

-- 
2.26.3

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2021-10-27 09:30:27

On Tue, 2021-10-26 at 20:39 +0300, Sergey Shtylyov wrote:

quoted hunk

If platform_get_irq() returns IRQ0 (considered invalid according to
Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no
IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe()
method...

Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host
controller")
Signed-off-by: Sergey Shtylyov <redacted>
---
 drivers/usb/host/xhci-mtk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-

mtk.c
index c53f6f276d5c..d2dc8d9863ee 100644

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c

@@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device

*pdev)
 		return ret;
 
 	irq = platform_get_irq_byname_optional(pdev, "host");
-	if (irq < 0) {
+	if (irq <= 0) {
 		if (irq == -EPROBE_DEFER)
 			return irq;

@@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device

*pdev)
 		irq = platform_get_irq(pdev, 0);
 		if (irq < 0)
 			return irq;
+		if (!irq)

it's "if (irq <= 0)"?

+			return -EINVAL;
 	}
 
 	wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0

From: Sergey Shtylyov <hidden>
Date: 2021-10-27 09:27:43

On 27.10.2021 12:18, Chunfeng Yun wrote:

quoted

If platform_get_irq() returns IRQ0 (considered invalid according to
Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no
IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe()
method...

Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host
controller")
Signed-off-by: Sergey Shtylyov <redacted>
---
  drivers/usb/host/xhci-mtk.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-

mtk.c
index c53f6f276d5c..d2dc8d9863ee 100644

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c

@@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device

*pdev)
  		return ret;
  
  	irq = platform_get_irq_byname_optional(pdev, "host");
-	if (irq < 0) {
+	if (irq <= 0) {
  		if (irq == -EPROBE_DEFER)
  			return irq;

@@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device

*pdev)
  		irq = platform_get_irq(pdev, 0);
  		if (irq < 0)
  			return irq;
+		if (!irq)

it's "if (irq <= 0)"?

    No, if (irq == 0).

quoted

+			return -EINVAL;
  	}
  
  	wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");

MBR, Sergey

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2021-10-27 09:43:11

On Wed, 2021-10-27 at 12:25 +0300, Sergey Shtylyov wrote:

On 27.10.2021 12:18, Chunfeng Yun wrote:

quoted

If platform_get_irq() returns IRQ0 (considered invalid according
to
Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0
as no
IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe()
method...

Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host
controller")
Signed-off-by: Sergey Shtylyov <redacted>
---
  drivers/usb/host/xhci-mtk.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-

mtk.c
index c53f6f276d5c..d2dc8d9863ee 100644

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c

@@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct

platform_device
*pdev)
  		return ret;
  
  	irq = platform_get_irq_byname_optional(pdev, "host");
-	if (irq < 0) {
+	if (irq <= 0) {
  		if (irq == -EPROBE_DEFER)
  			return irq;

@@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct

platform_device
*pdev)
  		irq = platform_get_irq(pdev, 0);

Here, irq is updated again

quoted

  		if (irq < 0)
  			return irq;
+		if (!irq)

it's "if (irq <= 0)"?

    No, if (irq == 0).

quoted

+			return -EINVAL;

add "else if (irq < 0), return irq;"?  but not -EINVAL only, this may
drop EPROBE_DEFER

quoted

  	}
  
  	wakeup_irq = platform_get_irq_byname_optional(pdev,
"wakeup");

MBR, Sergey

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2021-11-13 07:18:01

On Tue, 2021-10-26 at 20:39 +0300, Sergey Shtylyov wrote:

quoted hunk

If platform_get_irq() returns IRQ0 (considered invalid according to
Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no
IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe()
method...

Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host
controller")
Signed-off-by: Sergey Shtylyov <redacted>
---
 drivers/usb/host/xhci-mtk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-

mtk.c
index c53f6f276d5c..d2dc8d9863ee 100644

--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c

@@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device

*pdev)
 		return ret;
 
 	irq = platform_get_irq_byname_optional(pdev, "host");
-	if (irq < 0) {
+	if (irq <= 0) {
 		if (irq == -EPROBE_DEFER)
 			return irq;

@@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device

*pdev)
 		irq = platform_get_irq(pdev, 0);
 		if (irq < 0)
 			return irq;
+		if (!irq)

It is "if (irq <= 0)"?

+			return -EINVAL;
 	}
 
 	wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help