# Re: \[PATCH net-next 3/7\] ethernet: make use of eth\_hw\_addr\_random() where appropriate

- From: Linus Walleij \<hidden\>
- Date: 2021-10-13 23:52:50 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/10/8812794
- Thread: https://ratatoskr.run/netdev/2021/10/11213343/t.md

```text
On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski [ref] wrote:

> Number of drivers use eth_random_addr(netdev->dev_addr)
> thus writing to netdev->dev_addr directly, and not setting
> the address type. Switch them to eth_hw_addr_random().
>
>   @@
>   expression netdev;
>   @@
>   - eth_random_addr(netdev->dev_addr);
>   + eth_hw_addr_random(netdev);
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Oh this is better.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
