[PATCH] mfd: stmpe: Support disabling sub-functions

Subsystems: multifunction devices (mfd), the rest

STALE1711d LANDED

Landed in mainline as 786c6f140bb6 on 2021-11-29.

8 messages, 4 authors, 2021-11-24 · open the first message on its own page

[PATCH] mfd: stmpe: Support disabling sub-functions

From: Francesco Dolcini <hidden>
Date: 2021-10-27 08:22:14 

From: Oleksandr Suvorov <redacted>

Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.

Signed-off-by: Oleksandr Suvorov <redacted>
Cc: Oleksandr Suvorov <redacted>
Signed-off-by: Francesco Dolcini <redacted>
---
Hello,
the main reason for this patch is to allow enabling/disabling sub-fuctions
using DTS overlay to enable more flexibility on SoM/Carrier boards
combinations.
---
 drivers/mfd/stmpe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index e928df95e316..aeb9ea55f97d 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1361,7 +1361,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
 
 	pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
 
-	for_each_child_of_node(np, child) {
+	for_each_available_child_of_node(np, child) {
 		if (of_node_name_eq(child, "stmpe_gpio")) {
 			pdata->blocks |= STMPE_BLOCK_GPIO;
 		} else if (of_node_name_eq(child, "stmpe_keypad")) {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Marcel Ziswiler <hidden>
Date: 2021-10-27 16:14:43 

Hi Francesco

On Wed, 2021-10-27 at 10:21 +0200, Francesco Dolcini wrote:
From: Oleksandr Suvorov <redacted>

Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.

Signed-off-by: Oleksandr Suvorov <redacted>
Cc: Oleksandr Suvorov <redacted>
Signed-off-by: Francesco Dolcini <redacted>
Reviewed-by: Marcel Ziswiler <redacted>

---
Hello,
the main reason for this patch is to allow enabling/disabling sub-fuctions
:s/sub-fuctions/sub-functions/

using DTS overlay to enable more flexibility on SoM/Carrier boards
:s/boards/board/
quoted hunk
combinations.
---
 drivers/mfd/stmpe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index e928df95e316..aeb9ea55f97d 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1361,7 +1361,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
 
        pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
 
-       for_each_child_of_node(np, child) {
+       for_each_available_child_of_node(np, child) {
                if (of_node_name_eq(child, "stmpe_gpio")) {
                        pdata->blocks |= STMPE_BLOCK_GPIO;
                } else if (of_node_name_eq(child, "stmpe_keypad")) {
Cheers

Marcel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Linus Walleij <hidden>
Date: 2021-10-28 00:38:00 

On Wed, Oct 27, 2021 at 10:23 AM Francesco Dolcini
[off-list ref] wrote:

From: Oleksandr Suvorov <redacted>

Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.

Signed-off-by: Oleksandr Suvorov <redacted>
Cc: Oleksandr Suvorov <redacted>
Signed-off-by: Francesco Dolcini <redacted>
Looks helpful.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Francesco Dolcini <hidden>
Date: 2021-11-01 09:52:50 

On Wed, Oct 27, 2021 at 10:21:55AM +0200, Francesco Dolcini wrote:
From: Oleksandr Suvorov <redacted>

Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.

Signed-off-by: Oleksandr Suvorov <redacted>
Cc: Oleksandr Suvorov <redacted>
Signed-off-by: Francesco Dolcini <redacted>
Hello Lee,
any chance you could take this one line patch for this merge window?

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Lee Jones <hidden>
Date: 2021-11-01 12:13:33 

On Mon, 01 Nov 2021, Francesco Dolcini wrote:

On Wed, Oct 27, 2021 at 10:21:55AM +0200, Francesco Dolcini wrote:
quoted
From: Oleksandr Suvorov <redacted>

Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.

Signed-off-by: Oleksandr Suvorov <redacted>
Cc: Oleksandr Suvorov <redacted>
Signed-off-by: Francesco Dolcini <redacted>
Hello Lee,
any chance you could take this one line patch for this merge window?
For a patch sent 0.5 weeks before the merge-window?  Nope. :)

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Francesco Dolcini <hidden>
Date: 2021-11-02 08:21:59 

On Mon, Nov 01, 2021 at 12:13:23PM +0000, Lee Jones wrote:
On Mon, 01 Nov 2021, Francesco Dolcini wrote:
quoted
Hello Lee,
any chance you could take this one line patch for this merge window?
For a patch sent 0.5 weeks before the merge-window?  Nope. :)
Hello Lee,
no problem, I thought it was that trivial to not create any worries.
I'll resend it in a while unless you take it before.

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Lee Jones <hidden>
Date: 2021-11-02 10:48:55 

On Tue, 02 Nov 2021, Francesco Dolcini wrote:

On Mon, Nov 01, 2021 at 12:13:23PM +0000, Lee Jones wrote:
quoted
On Mon, 01 Nov 2021, Francesco Dolcini wrote:
quoted
Hello Lee,
any chance you could take this one line patch for this merge window?
For a patch sent 0.5 weeks before the merge-window?  Nope. :)
Hello Lee,
no problem, I thought it was that trivial to not create any worries.
I'll resend it in a while unless you take it before.
I like *all* patches to have a soak in -next.

You don't need to resend it.  I'll apply it in due course.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mfd: stmpe: Support disabling sub-functions

From: Lee Jones <hidden>
Date: 2021-11-24 15:45:41 

On Wed, 27 Oct 2021, Francesco Dolcini wrote:

From: Oleksandr Suvorov <redacted>

Add support of sub-functions disabling. It allows one to define
an stmpe sub-function device in devicetree, but keep it disabled.

Signed-off-by: Oleksandr Suvorov <redacted>
Cc: Oleksandr Suvorov <redacted>
Signed-off-by: Francesco Dolcini <redacted>
---
Hello,
the main reason for this patch is to allow enabling/disabling sub-fuctions
using DTS overlay to enable more flexibility on SoM/Carrier boards
combinations.
---
 drivers/mfd/stmpe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help