[PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY

Subsystems: arm64 port (aarch64 architecture), kernel virtual machine for arm64 (kvm/arm64), the rest

STALE1751d

4 messages, 3 authors, 2021-10-27 · open the first message on its own page

[PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY

From: Qian Cai <hidden>
Date: 2021-10-26 21:09:42

TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
GCC (W=2):

arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
   17 | #define TRNG_NO_ENTROPY   ((unsigned long)-3)

Signed-off-by: Qian Cai <redacted>
---
 arch/arm64/kvm/trng.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
index 99bdd7103c9c..6a46b3ac3970 100644
--- a/arch/arm64/kvm/trng.c
+++ b/arch/arm64/kvm/trng.c

@@ -14,7 +14,6 @@
 #define TRNG_SUCCESS			0UL
 #define TRNG_NOT_SUPPORTED		((unsigned long)-1)
 #define TRNG_INVALID_PARAMETER		((unsigned long)-2)
-#define TRNG_NO_ENTROPY			((unsigned long)-3)
 
 #define TRNG_MAX_BITS64			192

-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY

From: Will Deacon <will@kernel.org>
Date: 2021-10-27 07:37:15

On Tue, Oct 26, 2021 at 05:09:13PM -0400, Qian Cai wrote:

TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
GCC (W=2):

arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
   17 | #define TRNG_NO_ENTROPY   ((unsigned long)-3)

This return value is defined by the TRNG SMCCC spec (Arm DEN0098) so I'd
rather just keep it around given that it's not causing any problems.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY

From: Marc Zyngier <maz@kernel.org>
Date: 2021-10-27 07:46:48

On 2021-10-26 22:09, Qian Cai wrote:

quoted hunk

TRNG_NO_ENTROPY was unused when introduced and now. This is also caught 
by
GCC (W=2):

arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used
[-Wunused-macros]
   17 | #define TRNG_NO_ENTROPY   ((unsigned long)-3)

Signed-off-by: Qian Cai <redacted>
---
 arch/arm64/kvm/trng.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
index 99bdd7103c9c..6a46b3ac3970 100644
--- a/arch/arm64/kvm/trng.c
+++ b/arch/arm64/kvm/trng.c

@@ -14,7 +14,6 @@
 #define TRNG_SUCCESS			0UL
 #define TRNG_NOT_SUPPORTED		((unsigned long)-1)
 #define TRNG_INVALID_PARAMETER		((unsigned long)-2)
-#define TRNG_NO_ENTROPY			((unsigned long)-3)

 #define TRNG_MAX_BITS64			192

That's an architectural definition that doesn't cause any problem.
If anything, that's documentation.

We have *tons* of other definitions with no user all over the
arm64 code. They save the exact same purpose.

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY

From: Qian Cai <hidden>
Date: 2021-10-27 15:17:39


On 10/27/21 3:46 AM, Marc Zyngier wrote:

That's an architectural definition that doesn't cause any problem.
If anything, that's documentation.

We have *tons* of other definitions with no user all over the
arm64 code. They save the exact same purpose.

Understood. Thanks for the quick feedback, guys!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help