# Re: \[PATCH v2 0/5\] Refactor thermal pressure update to avoid code duplication

- From: Lukasz Luba \<lukasz.luba@arm.com\>
- Date: 2021-10-25 16:43:20 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2021/10/1552796
- Thread: https://ratatoskr.run/linux-pm/2021/10/1543491/t.md

```text

On 10/15/21 3:45 PM, Lukasz Luba wrote:
> Hi all,
>
> This patch set v2 aims to refactor the thermal pressure update
> code. There are already two clients which do similar thing:
> convert the capped frequency value into the capacity of
> affected CPU and call the 'set' function to store the
> reduced capacity into the per-cpu variable.
> There might be more than two of these users. In near future
> it will be scmi-cpufreq driver, which receives notification
> from FW about reduced frequency due to thermal. Other vendors
> might follow. Let's avoid code duplication and potential
> conversion bugs. Move the conversion code into the arch_topology.c
> where the capacity calculation setup code and thermal pressure sit.
>
> Apart from that $subject patches, there is one patch (3/5) which fixes
> issue in qcom-cpufreq-hw.c when the thermal pressure is not
> updated for offline CPUs. It's similar fix that has been merged
> recently for cpufreq_cooling.c:
> 2ad8ccc17d1e4270cf65a3f2
>
> Changes:
> v2:
> - added Reviewed-by from Thara for patch 3/5
> - changed the doxygen comment and used mult_frac()
>    according to Thara's suggestion in patch 1/5
> v1 -> [1]
>

Gentle ping.

Viresh, Daniel, Rafael could you have a look at this, please?

Regards,
Lukasz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
```
