[PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove function

'priv->workqueue' is destroyed in the error handling path of the probe but
not in the remove function.

Add the missing call to release some resources.

Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
Signed-off-by: Christophe JAILLET <redacted>
---
This patch is speculative. I'm not sure if the added function call is at
the right place in the remove function.
Review with care.
---
 drivers/remoteproc/imx_rproc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index ff8170dbbc3c..0a45bc0d3f73 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c

@@ -804,6 +804,7 @@ static int imx_rproc_remove(struct platform_device *pdev)
 	clk_disable_unprepare(priv->clk);
 	rproc_del(rproc);
 	imx_rproc_free_mbox(rproc);
+	destroy_workqueue(priv->workqueue);
 	rproc_free(rproc);
 
 	return 0;

-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On Sat, Oct 16, 2021 at 08:44:28AM +0200, Christophe JAILLET wrote:

This seems to be the right thing to do. Peng - please review and test on your
side.

Thanks,
Mathieu

 	rproc_free(rproc);
 
 	return 0;
-- 
2.30.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Subject: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
function

'priv->workqueue' is destroyed in the error handling path of the probe but not
in the remove function.

Add the missing call to release some resources.

Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
Signed-off-by: Christophe JAILLET <redacted>

Tested-by: Peng Fan <peng.fan@nxp.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Subject: Re: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the
remove function

On Sat, Oct 16, 2021 at 08:44:28AM +0200, Christophe JAILLET wrote:

quoted

'priv->workqueue' is destroyed in the error handling path of the probe
but not in the remove function.

Add the missing call to release some resources.

Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
Signed-off-by: Christophe JAILLET <redacted>
---
This patch is speculative. I'm not sure if the added function call is
at the right place in the remove function.
Review with care.
---
 drivers/remoteproc/imx_rproc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/imx_rproc.c

b/drivers/remoteproc/imx_rproc.c index ff8170dbbc3c..0a45bc0d3f73
100644

--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c

@@ -804,6 +804,7 @@ static int imx_rproc_remove(struct platform_device

*pdev)

quoted

 	clk_disable_unprepare(priv->clk);
 	rproc_del(rproc);
 	imx_rproc_free_mbox(rproc);
+	destroy_workqueue(priv->workqueue);

This seems to be the right thing to do. Peng - please review and test on your
side.

Sorry for late reply, I built the driver as a module with this patch. And no issue found.

THnaks,
Peng.

Thanks,
Mathieu

quoted

 	rproc_free(rproc);

 	return 0;
--
2.30.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Subject: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
function

'priv->workqueue' is destroyed in the error handling path of the probe but not
in the remove function.

Add the missing call to release some resources.

Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
Signed-off-by: Christophe JAILLET <redacted>

Reviewed-and-Tested-by: Peng Fan [off-list ref]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On Wed, 10 Nov 2021 at 01:54, Peng Fan [off-list ref] wrote:

quoted

Subject: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
function

'priv->workqueue' is destroyed in the error handling path of the probe but not
in the remove function.

Add the missing call to release some resources.

Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
Signed-off-by: Christophe JAILLET <redacted>

Reviewed-and-Tested-by: Peng Fan [off-list ref]

Thank you for that - I will pick up this patch when -rc1 or -rc2 gets released.

Thanks,
Mathieu

quoted

---
This patch is speculative. I'm not sure if the added function call is at the right
place in the remove function.
Review with care.
---
 drivers/remoteproc/imx_rproc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/imx_rproc.c

b/drivers/remoteproc/imx_rproc.c index ff8170dbbc3c..0a45bc0d3f73
100644

--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c

@@ -804,6 +804,7 @@ static int imx_rproc_remove(struct platform_device

*pdev)
      clk_disable_unprepare(priv->clk);
      rproc_del(rproc);
      imx_rproc_free_mbox(rproc);
+     destroy_workqueue(priv->workqueue);
      rproc_free(rproc);

      return 0;
--
2.30.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel