[PATCH] ARM: dove: Add of_node_put() before break
From: Wan Jiabing <hidden>
Date: 2021-10-15 06:40:27
Also in:
lkml
Subsystem:
arm/marvell dove/mv78xx0/orion soc support, the rest · Maintainers:
Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Linus Torvalds
Fix following coccicheck warning: ./drivers/soc/dove/pmu.c:408:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before break Early exits from for_each_available_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing <redacted> --- drivers/soc/dove/pmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index ffc5311c0ed8..6202dbcd20a8 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c@@ -410,13 +410,16 @@ int __init dove_init_pmu(void) struct pmu_domain *domain; domain = kzalloc(sizeof(*domain), GFP_KERNEL); - if (!domain) + if (!domain) { + of_node_put(np); break; + } domain->pmu = pmu; domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np); if (!domain->base.name) { kfree(domain); + of_node_put(np); break; }
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel