[PATCH 1/4] ARM: dts: imx6qdl-apalis: Avoid underscore in node name
Subsystems:
the rest
1831d
5 messages,
2 authors,
2021-10-05 · open the first message on its own page
It is recommended not to use underscore in node names.
Change it to dash.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 30fa349f9d05..7c6d9c75d2bf 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -313,7 +313,7 @@ stmpe811@41 {
/* ADC converstion time: 80 clocks */
st , sample-time = < 4 > ;
- stmpe_touchscreen { + stmpe-touchscreen { compatible = "st,stmpe-ts" ;
/* 8 sample average control */
st , ave-ctrl = < 3 > ; @@ -330,7 +330,7 @@ stmpe_touchscreen {
st , touch-det-delay = < 5 > ;
};
- stmpe_adc { + stmpe-adc { compatible = "st,stmpe-adc" ;
/* forbid to use ADC channels 3-0 (touch) */
st , norequest-mask = < 0x0F > ; --
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
The STMPE811 ADC on the Apalis SoM board can be used as a provider
of ADC capabilities to other devices, for example, when a custom
baseboard has an SN74LV4051 analog mux.
Pass the 'io-channel-cells' parameter to indicate such possibility.
While at it, also pass a label for the adc device, so that it can
be referenced in the custom baseboard.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 7c6d9c75d2bf..4092af5f6999 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -330,10 +330,11 @@ stmpe-touchscreen {
st , touch-det-delay = < 5 > ;
};
- stmpe-adc { + stmpe_adc : stmpe-adc { compatible = "st,stmpe-adc" ;
/* forbid to use ADC channels 3-0 (touch) */
st , norequest-mask = < 0x0F > ;
+ # io-channel-cells = < 1 > ; };
};
}; --
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Add a label for the touchscreen to allow a custom baseboard to
disable this node if needed.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index 4092af5f6999..aae60ffac623 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -313,7 +313,7 @@ stmpe811@41 {
/* ADC converstion time: 80 clocks */
st , sample-time = < 4 > ;
- stmpe-touchscreen { + stmpe_touchscreen : stmpe-touchscreen { compatible = "st,stmpe-ts" ;
/* 8 sample average control */
st , ave-ctrl = < 3 > ; --
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fix the spelling of 'conversion'.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-apalis.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
index aae60ffac623..ed2739e39085 100644
--- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -310,7 +310,7 @@ stmpe811@41 {
st , mod-12b = < 1 > ;
/* internal ADC reference */
st , ref-sel = < 0 > ;
- /* ADC converstion time: 80 clocks */ + /* ADC conversion time: 80 clocks */ st , sample-time = < 4 > ;
stmpe_touchscreen : stmpe-touchscreen { --
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fri, Sep 24, 2021 at 10:46:42AM -0300, Fabio Estevam wrote: It is recommended not to use underscore in node names.
Change it to dash.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied all, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel