[PATCH] soc: samsung: exynos-pmu: select CONFIG_MFD_CORE

Subsystems: arm/samsung s3c, s5p and exynos arm architectures, the rest

STALE1843d

2 messages, 2 authors, 2021-09-20 · open the first message on its own page

[PATCH] soc: samsung: exynos-pmu: select CONFIG_MFD_CORE

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-09-20 10:08:00

From: Arnd Bergmann <arnd@arndb.de>

Using devm_mfd_add_devices() fails if no driver selects the
MFD core code:

aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'

Add the missing select statement.

Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
index 5745d7e5908e..1f643c0f5c93 100644
--- a/drivers/soc/samsung/Kconfig
+++ b/drivers/soc/samsung/Kconfig
@@ -25,6 +25,7 @@ config EXYNOS_PMU
 	bool "Exynos PMU controller driver" if COMPILE_TEST
 	depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
 	select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
+	select MFD_CORE
 
 # There is no need to enable these drivers for ARMv8
 config EXYNOS_PMU_ARM_DRIVERS
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] soc: samsung: exynos-pmu: select CONFIG_MFD_CORE

From: Krzysztof Kozlowski <hidden>
Date: 2021-09-20 10:28:58

On 20/09/2021 12:06, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>

Using devm_mfd_add_devices() fails if no driver selects the
MFD core code:

aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'

Add the missing select statement.

Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Hi Arnd,

Thanks for the patch but this was already committed few days ago from
different author:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/drivers&id=e37ef6dcdb1f4738b01cec7fb7be46af07816af9


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help