[PATCH 0/3] renesas: Add missing Ethernet PHY resets

STALE1855d

4 messages, 1 author, 2021-09-09 · open the first message on its own page

[PATCH 0/3] renesas: Add missing Ethernet PHY resets

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2021-09-09 09:05:31

	Hi all,

This patch series adds Ethernet PHY resets to board DTS files that lack
them.  This allows software to control the PHY assert, and avoid relying
solely on boot loaders to bring PHYs out of reset.

To avoid kexec/unbind regressions, this depends on "[PATCH 0/9] renesas:
Add compatible properties to Ethernet PHY nodes"[1].

Thanks for your comments!

[1] https://lore.kernel.org/r/cover.1631174218.git.geert+renesas@glider.be

Geert Uytterhoeven (3):
  ARM: dts: r-mobile: Add missing Ethernet PHY resets
  ARM: dts: rzg1: Add missing Ethernet PHY resets
  arm64: dts: renesas: rcar-gen3: Add missing Ethernet PHY resets

 arch/arm/boot/dts/r8a73a4-ape6evm.dts           | 1 +
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts   | 1 +
 arch/arm/boot/dts/r8a7743-sk-rzg1m.dts          | 2 ++
 arch/arm/boot/dts/r8a7745-sk-rzg1e.dts          | 2 ++
 arch/arm64/boot/dts/renesas/draak.dtsi          | 1 +
 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts  | 1 +
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts  | 2 ++
 arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 2 ++
 arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts  | 2 ++
 9 files changed, 14 insertions(+)

-- 
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/3] arm64: dts: renesas: rcar-gen3: Add missing Ethernet PHY resets

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2021-09-09 09:05:29

Describe all Ethernet PHY reset GPIOs on R-Car Gen3 boards, to avoid
relying solely on boot loaders to bring PHYs out of reset.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This assumes the CPLD on v3hsk takes care of the PHY reset, like it is
documented to do on v3msk.
---
 arch/arm64/boot/dts/renesas/draak.dtsi          | 1 +
 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts  | 1 +
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts  | 2 ++
 arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 2 ++
 arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts  | 2 ++
 5 files changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
index 5f5a0bb2da86cc57..eb0327c0df48f2e3 100644
--- a/arch/arm64/boot/dts/renesas/draak.dtsi
+++ b/arch/arm64/boot/dts/renesas/draak.dtsi

@@ -249,6 +249,7 @@ phy0: ethernet-phy@0 {
 		reg = <0>;
 		interrupt-parent = <&gpio5>;
 		interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&gpio5 18 GPIO_ACTIVE_LOW>;
 		/*
 		 * TX clock internal delay mode is required for reliable
 		 * 1Gbps communication using the KSZ9031RNX phy present on

diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
index c7451973f8a5b2a7..6586a3bd51b4aad6 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts

@@ -98,6 +98,7 @@ phy0: ethernet-phy@0 {
 		reg = <0>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
 	};
 };

diff --git a/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts b/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
index 2f77ec4ed7e16166..39f3e6cbba3d500f 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts

@@ -8,6 +8,7 @@
 
 /dts-v1/;
 #include "r8a77970.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Renesas V3M Starter Kit board";

@@ -113,6 +114,7 @@ phy0: ethernet-phy@0 {
 		reg = <0>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
 	};
 };

diff --git a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
index 4cb5bfa6932d5809..3d6d10c82f48d667 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts

@@ -8,6 +8,7 @@
 
 /dts-v1/;
 #include "r8a77980.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Renesas Condor board based on r8a77980";

@@ -138,6 +139,7 @@ phy0: ethernet-phy@0 {
 		reg = <0>;
 		interrupt-parent = <&gpio4>;
 		interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
 	};
 };

diff --git a/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts b/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
index ca69d1b1d67af047..1d09d8867651a06b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts

@@ -8,6 +8,7 @@
 
 /dts-v1/;
 #include "r8a77980.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Renesas V3H Starter Kit board";

@@ -118,6 +119,7 @@ phy0: ethernet-phy@0 {
 		reg = <0>;
 		interrupt-parent = <&gpio4>;
 		interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
 	};
 };

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/3] ARM: dts: r-mobile: Add missing Ethernet PHY resets

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2021-09-09 09:05:38

Describe all Ethernet PHY reset GPIOs on R-Mobile boards, to avoid
relying solely on boot loaders to bring PHYs out of reset.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a73a4-ape6evm.dts         | 1 +
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
index dc2fdc17312d39c7..e6b0b4151655e0e2 100644
--- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
+++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts

@@ -206,6 +206,7 @@ ethernet@8000000 {
 		reg-io-width = <4>;
 		smsc,irq-active-high;
 		smsc,irq-push-pull;
+		reset-gpios = <&pfc 270 GPIO_ACTIVE_LOW>;
 		vdd33a-supply = <&ape6evm_fixed_3v3>;
 		vddvario-supply = <&ape6evm_fixed_1v8>;
 	};

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index f052f8bade5d9c78..c3ca693b91daebed 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts

@@ -183,6 +183,7 @@ phy0: ethernet-phy@0 {
 		compatible = "ethernet-phy-id0007.c0f1",
 			     "ethernet-phy-ieee802.3-c22";
 		reg = <0>;
+		reset-gpios = <&pfc 18 GPIO_ACTIVE_LOW>;
 	};
 };

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/3] ARM: dts: rzg1: Add missing Ethernet PHY resets

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2021-09-09 09:05:43

Describe all Ethernet PHY reset GPIOs on RZ/G1 boards, to avoid relying
solely on boot loaders to bring PHYs out of reset.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7743-sk-rzg1m.dts | 2 ++
 arch/arm/boot/dts/r8a7745-sk-rzg1e.dts | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743-sk-rzg1m.dts b/arch/arm/boot/dts/r8a7743-sk-rzg1m.dts
index ce36cf404fa2b1c4..ff274bfcb6646ea7 100644
--- a/arch/arm/boot/dts/r8a7743-sk-rzg1m.dts
+++ b/arch/arm/boot/dts/r8a7743-sk-rzg1m.dts

@@ -7,6 +7,7 @@
 
 /dts-v1/;
 #include "r8a7743.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "SK-RZG1M";

@@ -75,5 +76,6 @@ phy1: ethernet-phy@1 {
 		interrupt-parent = <&irqc>;
 		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
 		micrel,led-mode = <1>;
+		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
 	};
 };

diff --git a/arch/arm/boot/dts/r8a7745-sk-rzg1e.dts b/arch/arm/boot/dts/r8a7745-sk-rzg1e.dts
index 4ab6d3fcc857f7db..0a75e8c79acc0e58 100644
--- a/arch/arm/boot/dts/r8a7745-sk-rzg1e.dts
+++ b/arch/arm/boot/dts/r8a7745-sk-rzg1e.dts

@@ -7,6 +7,7 @@
 
 /dts-v1/;
 #include "r8a7745.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "SK-RZG1E";

@@ -70,5 +71,6 @@ phy1: ethernet-phy@1 {
 		interrupt-parent = <&irqc>;
 		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
 		micrel,led-mode = <1>;
+		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
 	};
 };

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help