[PATCH] pwm: samsung: Simplify using devm_pwmchip_add()

Subsystems: arm/samsung s3c, s5p and exynos arm architectures, pwm subsystem, the rest

STALE1874d

3 messages, 2 authors, 2021-09-01 · open the first message on its own page

[PATCH] pwm: samsung: Simplify using devm_pwmchip_add()

From: zhaoxiao <hidden>
Date: 2021-09-01 05:45:14 

With devm_pwmchip_add() we can drop pwmchip_remove() from the device
remove callback. The latter can then go away, too and as this is the
only user of platform_get_drvdata(), the respective call to
platform_set_drvdata() can go, too.

Signed-off-by: zhaoxiao <redacted>
---
 drivers/pwm/pwm-samsung.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index f6c528f02d43..b860a7b8bbdf 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -560,9 +560,7 @@ static int pwm_samsung_probe(struct platform_device *pdev)
 	chip->tclk0 = devm_clk_get(&pdev->dev, "pwm-tclk0");
 	chip->tclk1 = devm_clk_get(&pdev->dev, "pwm-tclk1");
 
-	platform_set_drvdata(pdev, chip);
-
-	ret = pwmchip_add(&chip->chip);
+	ret = devm_pwmchip_add(&pdev->dev, &chip->chip);
 	if (ret < 0) {
 		dev_err(dev, "failed to register PWM chip\n");
 		clk_disable_unprepare(chip->base_clk);
@@ -577,19 +575,6 @@ static int pwm_samsung_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int pwm_samsung_remove(struct platform_device *pdev)
-{
-	struct samsung_pwm_chip *chip = platform_get_drvdata(pdev);
-	int ret;
-
-	ret = pwmchip_remove(&chip->chip);
-	if (ret < 0)
-		return ret;
-
-	clk_disable_unprepare(chip->base_clk);
-
-	return 0;
-}
 
 #ifdef CONFIG_PM_SLEEP
 static int pwm_samsung_resume(struct device *dev)
@@ -635,7 +620,6 @@ static struct platform_driver pwm_samsung_driver = {
 		.of_match_table = of_match_ptr(samsung_pwm_matches),
 	},
 	.probe		= pwm_samsung_probe,
-	.remove		= pwm_samsung_remove,
 };
 module_platform_driver(pwm_samsung_driver);
 
-- 
2.20.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Simplify using devm_pwmchip_add()

From: Krzysztof Kozlowski <hidden>
Date: 2021-09-01 08:56:23 

On 01/09/2021 07:42, zhaoxiao wrote:
quoted hunk
With devm_pwmchip_add() we can drop pwmchip_remove() from the device
remove callback. The latter can then go away, too and as this is the
only user of platform_get_drvdata(), the respective call to
platform_set_drvdata() can go, too.

Signed-off-by: zhaoxiao <redacted>
---
 drivers/pwm/pwm-samsung.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index f6c528f02d43..b860a7b8bbdf 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -560,9 +560,7 @@ static int pwm_samsung_probe(struct platform_device *pdev)
 	chip->tclk0 = devm_clk_get(&pdev->dev, "pwm-tclk0");
 	chip->tclk1 = devm_clk_get(&pdev->dev, "pwm-tclk1");
 
-	platform_set_drvdata(pdev, chip);
The test looks untested because this should cause bug during resume.
quoted hunk
-
-	ret = pwmchip_add(&chip->chip);
+	ret = devm_pwmchip_add(&pdev->dev, &chip->chip);
 	if (ret < 0) {
 		dev_err(dev, "failed to register PWM chip\n");
 		clk_disable_unprepare(chip->base_clk);
@@ -577,19 +575,6 @@ static int pwm_samsung_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int pwm_samsung_remove(struct platform_device *pdev)
-{
-	struct samsung_pwm_chip *chip = platform_get_drvdata(pdev);
-	int ret;
-
-	ret = pwmchip_remove(&chip->chip);
-	if (ret < 0)
-		return ret;
-
-	clk_disable_unprepare(chip->base_clk);
NAK, the patch looks bad. You cannot remove some code from remove()
callback just "because".


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: samsung: Simplify using devm_pwmchip_add()

From: zhaoxiao <hidden>
Date: 2021-09-01 09:48:17 

Thanks for your advices, This patch is modified with reference to the patch that has been submitted，example:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=66a03c4fd9e95e192c574811a1f4ea8f62992358

在 2021/9/1 下午4:56, Krzysztof Kozlowski 写道:
On 01/09/2021 07:42, zhaoxiao wrote:
quoted
With devm_pwmchip_add() we can drop pwmchip_remove() from the device
remove callback. The latter can then go away, too and as this is the
only user of platform_get_drvdata(), the respective call to
platform_set_drvdata() can go, too.

Signed-off-by: zhaoxiao <redacted>
---
  drivers/pwm/pwm-samsung.c | 18 +-----------------
  1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index f6c528f02d43..b860a7b8bbdf 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -560,9 +560,7 @@ static int pwm_samsung_probe(struct platform_device *pdev)
  	chip->tclk0 = devm_clk_get(&pdev->dev, "pwm-tclk0");
  	chip->tclk1 = devm_clk_get(&pdev->dev, "pwm-tclk1");
  
-	platform_set_drvdata(pdev, chip);
The test looks untested because this should cause bug during resume.
quoted
-
-	ret = pwmchip_add(&chip->chip);
+	ret = devm_pwmchip_add(&pdev->dev, &chip->chip);
  	if (ret < 0) {
  		dev_err(dev, "failed to register PWM chip\n");
  		clk_disable_unprepare(chip->base_clk);
@@ -577,19 +575,6 @@ static int pwm_samsung_probe(struct platform_device *pdev)
  	return 0;
  }
  
-static int pwm_samsung_remove(struct platform_device *pdev)
-{
-	struct samsung_pwm_chip *chip = platform_get_drvdata(pdev);
-	int ret;
-
-	ret = pwmchip_remove(&chip->chip);
-	if (ret < 0)
-		return ret;
-
-	clk_disable_unprepare(chip->base_clk);
NAK, the patch looks bad. You cannot remove some code from remove()
callback just "because".


Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help