From: Cai Huoqing <hidden> Date: 2021-09-16 15:33:35
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <redacted>
---
drivers/input/keyboard/lpc32xx-keys.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
@@ -227,10 +227,9 @@ static int lpc32xx_kscan_probe(struct platform_device *pdev)/* Get the key scanner clock */kscandat->clk=devm_clk_get(&pdev->dev,NULL);-if(IS_ERR(kscandat->clk)){-dev_err(&pdev->dev,"failed to get clock\n");-returnPTR_ERR(kscandat->clk);-}+if(IS_ERR(kscandat->clk))+returndev_err_probe(&pdev->dev,PTR_ERR(kscandat->clk),+"failed to get clock\n");/* Configure the key scanner */error=clk_prepare_enable(kscandat->clk);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Vladimir Zapolskiy <vz@mleia.com> Date: 2021-09-16 20:08:40
Hi Cai,
On 9/16/21 6:33 PM, Cai Huoqing wrote:
quoted hunk
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <redacted>
---
drivers/input/keyboard/lpc32xx-keys.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
@@ -227,10 +227,9 @@ static int lpc32xx_kscan_probe(struct platform_device *pdev)/* Get the key scanner clock */kscandat->clk=devm_clk_get(&pdev->dev,NULL);-if(IS_ERR(kscandat->clk)){-dev_err(&pdev->dev,"failed to get clock\n");-returnPTR_ERR(kscandat->clk);-}+if(IS_ERR(kscandat->clk))+returndev_err_probe(&pdev->dev,PTR_ERR(kscandat->clk),+"failed to get clock\n");/* Configure the key scanner */error=clk_prepare_enable(kscandat->clk);
thank you for the change!
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel