[PATCH] mtd: rawnand: atmel: Make use of the helper function devm_platform_ioremap_resource()

Subsystems: memory technology devices (mtd), microchip nand driver, nand flash subsystem, the rest

STALE1862d LANDED

Landed in mainline as c606d4f77c8a on 2021-09-14.

3 messages, 3 authors, 2021-09-14 · open the first message on its own page

[PATCH] mtd: rawnand: atmel: Make use of the helper function devm_platform_ioremap_resource()

From: Cai Huoqing <hidden>
Date: 2021-09-01 07:40:45

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <redacted>
---
 drivers/mtd/nand/raw/atmel/pmecc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c b/drivers/mtd/nand/raw/atmel/pmecc.c
index cbb023bf00f7..498e41ccabbd 100644
--- a/drivers/mtd/nand/raw/atmel/pmecc.c
+++ b/drivers/mtd/nand/raw/atmel/pmecc.c
@@ -834,7 +834,6 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
 {
 	struct device *dev = &pdev->dev;
 	struct atmel_pmecc *pmecc;
-	struct resource *res;
 
 	pmecc = devm_kzalloc(dev, sizeof(*pmecc), GFP_KERNEL);
 	if (!pmecc)
@@ -844,13 +843,11 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
 	pmecc->dev = dev;
 	mutex_init(&pmecc->lock);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, pmecc_res_idx);
-	pmecc->regs.base = devm_ioremap_resource(dev, res);
+	pmecc->regs.base = devm_platform_ioremap_resource(pdev, pmecc_res_idx);
 	if (IS_ERR(pmecc->regs.base))
 		return ERR_CAST(pmecc->regs.base);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, errloc_res_idx);
-	pmecc->regs.errloc = devm_ioremap_resource(dev, res);
+	pmecc->regs.errloc = devm_platform_ioremap_resource(pdev, errloc_res_idx);
 	if (IS_ERR(pmecc->regs.errloc))
 		return ERR_CAST(pmecc->regs.errloc);
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mtd: rawnand: atmel: Make use of the helper function devm_platform_ioremap_resource()

From: Nicolas Ferre <nicolas.ferre@microchip.com>
Date: 2021-09-01 09:52:04

On 01/09/2021 at 09:40, Cai Huoqing wrote:
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <redacted>
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>
quoted hunk
---
  drivers/mtd/nand/raw/atmel/pmecc.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c b/drivers/mtd/nand/raw/atmel/pmecc.c
index cbb023bf00f7..498e41ccabbd 100644
--- a/drivers/mtd/nand/raw/atmel/pmecc.c
+++ b/drivers/mtd/nand/raw/atmel/pmecc.c
@@ -834,7 +834,6 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
  {
         struct device *dev = &pdev->dev;
         struct atmel_pmecc *pmecc;
-       struct resource *res;

         pmecc = devm_kzalloc(dev, sizeof(*pmecc), GFP_KERNEL);
         if (!pmecc)
@@ -844,13 +843,11 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
         pmecc->dev = dev;
         mutex_init(&pmecc->lock);

-       res = platform_get_resource(pdev, IORESOURCE_MEM, pmecc_res_idx);
-       pmecc->regs.base = devm_ioremap_resource(dev, res);
+       pmecc->regs.base = devm_platform_ioremap_resource(pdev, pmecc_res_idx);
         if (IS_ERR(pmecc->regs.base))
                 return ERR_CAST(pmecc->regs.base);

-       res = platform_get_resource(pdev, IORESOURCE_MEM, errloc_res_idx);
-       pmecc->regs.errloc = devm_ioremap_resource(dev, res);
+       pmecc->regs.errloc = devm_platform_ioremap_resource(pdev, errloc_res_idx);
         if (IS_ERR(pmecc->regs.errloc))
                 return ERR_CAST(pmecc->regs.errloc);

--
2.25.1

-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mtd: rawnand: atmel: Make use of the helper function devm_platform_ioremap_resource()

From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2021-09-14 17:40:50

On Wed, 2021-09-01 at 07:40:30 UTC, Cai Huoqing wrote:
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <redacted>
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help