[PATCH] arm64/sve: Add some comments for sve_save/load_state()

Subsystems: arm64 port (aarch64 architecture), the rest

STALE1840d LANDED

Landed in mainline as 38ee3c5e36a1 on 2021-08-24.

2 messages, 2 authors, 2021-08-24 · open the first message on its own page

[PATCH] arm64/sve: Add some comments for sve_save/load_state()

From: Mark Brown <broonie@kernel.org>
Date: 2021-08-12 20:28:12

The use of macros for the actual function bodies means legibility is always
going to be a bit of a challenge, especially while we can't rely on SVE
support in the toolchain, but this helps a little.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/kernel/entry-fpsimd.S | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/arch/arm64/kernel/entry-fpsimd.S b/arch/arm64/kernel/entry-fpsimd.S
index 0a7a64753878..196e921f61de 100644
--- a/arch/arm64/kernel/entry-fpsimd.S
+++ b/arch/arm64/kernel/entry-fpsimd.S
@@ -33,11 +33,24 @@ SYM_FUNC_END(fpsimd_load_state)
 
 #ifdef CONFIG_ARM64_SVE
 
+/*
+ * Save the SVE state
+ *
+ * x0 - pointer to buffer for state
+ * x1 - pointer to storage for FPSR
+ */
 SYM_FUNC_START(sve_save_state)
 	sve_save 0, x1, 2
 	ret
 SYM_FUNC_END(sve_save_state)
 
+/*
+ * Load the SVE state
+ *
+ * x0 - pointer to buffer for state
+ * x1 - pointer to storage for FPSR
+ * x2 - VQ-1
+ */
 SYM_FUNC_START(sve_load_state)
 	sve_load 0, x1, x2, 3, x4
 	ret
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64/sve: Add some comments for sve_save/load_state()

From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2021-08-24 16:19:51

On Thu, 12 Aug 2021 21:11:43 +0100, Mark Brown wrote:
The use of macros for the actual function bodies means legibility is always
going to be a bit of a challenge, especially while we can't rely on SVE
support in the toolchain, but this helps a little.
Applied to arm64 (for-next/misc), thanks!

[1/1] arm64/sve: Add some comments for sve_save/load_state()
      https://git.kernel.org/arm64/c/38ee3c5e36a1

-- 
Catalin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help